[WIP] Enable SPM in Jaeger v2 #5680
Conversation
| networks: | ||
| - backend | ||
| # TODO: Need to use the local image here while making changes | ||
| image: jaegertracing/jaeger |
There was a problem hiding this comment.
follow the same pattern as in the other compose file - env var defaulted to latest but make dev uses local build
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5680 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 329 329
Lines 16060 16060
=======================================
Hits 15477 15477
Misses 405 405
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| # TODO: Need to use the local image here while making changes | ||
| image: jaegertracing/jaeger | ||
| volumes: | ||
| - "./jaeger-ui.json:/etc/jaeger/jaeger-ui.json" # Do we need this for v2 ? Seems to be running without this. |
There was a problem hiding this comment.
it has this:
"monitor": {
"menuEnabled": true
},
I don't remember if it's the default. We already have a Capabilities exchange protocol between backend and UI, ideally it would just use that and not require explicit config.
| - backend | ||
| image: yurishkuro/microsim:0.3.0 | ||
| # TODO: Fix error - dial tcp [::1]:14278: connect: connection refused | ||
| command: "-j http://localhost:14278/api/traces -d 24h -s 500ms" |
There was a problem hiding this comment.
Does microsim support exporting via OTLP? If not, might be a good thing to implement.
|
Looks like I had some merge conflicts. I will open a new PR with the updated changes. Sorry for the trouble. |
Which problem is this PR solving?
Description of the changes
How was this change tested?
docker compose -f docker-compose-v2.yml upTODO
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test