Fix SPM clearn-all

[hellspawn679]

Which problem is this PR solving?

• make clean-all was not working for docker-compose/monitor/Makefile

Description of the changes

• update docker-compose/monitor/Makefile clean-all

How was this change tested?

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.13%. Comparing base (be558df) to head (1b46940).

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #5677       +/-   ##
===========================================
- Coverage   96.38%   54.13%   -42.25%     
===========================================
  Files         329      163      -166     
  Lines       16060     8412     -7648     
===========================================
- Hits        15479     4554    -10925     
- Misses        404     3414     +3010     
- Partials      177      444      +267     

Flag	Coverage Δ
badger_v1	8.04% <ø> (ø)
badger_v2	?
cassandra-3.x-v1	16.60% <ø> (ø)
cassandra-3.x-v2	1.84% <ø> (ø)
cassandra-4.x-v1	16.60% <ø> (ø)
cassandra-4.x-v2	?
elasticsearch-7.x-v1	18.87% <ø> (ø)
elasticsearch-8.x-v1	19.08% <ø> (ø)
elasticsearch-8.x-v2	19.08% <ø> (+0.01%)	⬆️
grpc_v1	9.47% <ø> (ø)
grpc_v2	?
kafka	9.76% <ø> (ø)
opensearch-1.x-v1	18.93% <ø> (+0.01%)	⬆️
opensearch-2.x-v1	18.93% <ø> (ø)
opensearch-2.x-v2	18.93% <ø> (ø)
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

what "wasn't working" specifically?

[hellspawn679]

what "wasn't working" specifically?

[yurishkuro]

looks fine to me. If you don't have latest tags they obviously cannot be purged, but the command didn't fail.

[hellspawn679]

looks fine to me. If you don't have latest tags they obviously cannot be purged, but the command didn't fail.

so we can add a make command like clean-all-dev to remove docker images for when we use make dev and update the docs

[yurishkuro]

why do we need to add anything? The command works. Even when there is nothing to remove:

$ make clean-all
# Also cleans up intermediate cached containers.
docker system prune -f
Total reclaimed space: 0B
docker rmi -f jaegertracing/all-in-one:dev ; \
	docker rmi -f jaegertracing/all-in-one:latest ; \
	docker rmi -f otel/opentelemetry-collector-contrib:latest ; \
	docker rmi -f prom/prometheus:latest ; \
	docker rmi -f grafana/grafana:latest
Error response from daemon: No such image: jaegertracing/all-in-one:dev
Error response from daemon: No such image: jaegertracing/all-in-one:latest
Error response from daemon: No such image: otel/opentelemetry-collector-contrib:latest
Error response from daemon: No such image: prom/prometheus:latest
Error response from daemon: No such image: grafana/grafana:latest