Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPM integration tests #5640

Merged
merged 23 commits into from
Jun 24, 2024
Merged

Add SPM integration tests #5640

merged 23 commits into from
Jun 24, 2024

Conversation

hellspawn679
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • changelog: added basic build test for SPM

How was this change tested?

Checklist

@hellspawn679
added SPM test
bfa5532 
Signed-off-by: mehul gautam <[email protected]>
@hellspawn679 hellspawn679 requested a review from a team as a code owner June 16, 2024 20:59
@hellspawn679 hellspawn679 requested a review from jkowall June 16, 2024 20:59
@codecov Codecov
Copy link

codecov bot commented Jun 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (afdd311) to head (50ce07a).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5640      +/-   ##
==========================================
+ Coverage   96.36%   96.38%   +0.01%     
==========================================
  Files         329      329              
  Lines       16060    16060              
==========================================
+ Hits        15477    15479       +2     
+ Misses        405      404       -1     
+ Partials      178      177       -1
Flag Coverage Δ
badger_v1 8.04% <ø> (ø)
badger_v2 ?
cassandra-3.x-v1 16.60% <ø> (ø)
cassandra-3.x-v2 1.84% <ø> (ø)
cassandra-4.x-v1 16.60% <ø> (ø)
cassandra-4.x-v2 1.84% <ø> (ø)
elasticsearch-7.x-v1 18.87% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v1 19.07% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 19.08% <ø> (ø)
grpc_v1 9.47% <ø> (+0.01%) ⬆️
grpc_v2 ?
kafka 9.76% <ø> (ø)
opensearch-1.x-v1 18.92% <ø> (ø)
opensearch-2.x-v1 18.92% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 18.93% <ø> (+0.01%) ⬆️
unittests 94.23% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 16, 2024
yurishkuro
yurishkuro reviewed Jun 16, 2024
View reviewed changes
scripts/build-SPM.sh Outdated Show resolved Hide resolved
yurishkuro
yurishkuro reviewed Jun 16, 2024
View reviewed changes
.github/workflows/ci-build-spm.yml Outdated Show resolved Hide resolved
.github/workflows/ci-build-spm.yml Outdated Show resolved Hide resolved
.github/workflows/ci-build-spm.yml Outdated Show resolved Hide resolved
scripts/build-SPM.sh Outdated Show resolved Hide resolved
@hellspawn679 hellspawn679 changed the title added SPM test Add SPM integration tests Jun 17, 2024
@FlamingSaint
Copy link
Member

@hellspawn679 please make the suggested changes by @yurishkuro. If you need any help in getting this PR merged please let me know.

@hellspawn679 hellspawn679 requested a review from yurishkuro June 18, 2024 19:04
yurishkuro
yurishkuro reviewed Jun 18, 2024
View reviewed changes
scripts/build-SPM.sh Outdated Show resolved Hide resolved
yurishkuro
yurishkuro reviewed Jun 18, 2024
View reviewed changes
scripts/build-SPM.sh Outdated Show resolved Hide resolved
yurishkuro
yurishkuro reviewed Jun 18, 2024
View reviewed changes
scripts/build-SPM.sh Outdated Show resolved Hide resolved
@hellspawn679
minor changes
78f26bb 
Signed-off-by: mehul gautam <[email protected]>
@yurishkuro yurishkuro mentioned this pull request Jun 19, 2024
Merged
yurishkuro added a commit that referenced this pull request Jun 19, 2024
@yurishkuro @hellspawn679
Add SPM build to CI (#5663)
f5d175b 
## Which problem is this PR solving?
- Part of #5608
- SPM Makefile was calling a target that was removed in previous
refactoring

## Description of the changes
- Build the image directly instead of calling much more expensive target
- Use workflow added in #5640 to run the build
- Change crossdock target to not build debug image with devle, which is
expensive

## How was this change tested?
- `make build && make dev`

---------

Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: mehul gautam <[email protected]>
yurishkuro and others added 2 commits June 19, 2024 14:23
@yurishkuro
Merge branch 'main' into spm
5dc699f 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
fix
320f8b2 
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro and others added 3 commits June 19, 2024 14:46
@yurishkuro @FlamingSaint
Update .github/workflows/ci-build-spm.yml
eda16cd 
Co-authored-by: Raghuram Kannan <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@hellspawn679
fix
0b190ae 
Signed-off-by: mehul gautam <[email protected]>
@hellspawn679
minor fix
e863844 
Signed-off-by: mehul gautam <[email protected]>
@hellspawn679 hellspawn679 requested a review from yurishkuro June 21, 2024 12:51
yurishkuro
yurishkuro reviewed Jun 21, 2024
View reviewed changes
scripts/spm-integration-test.sh Outdated Show resolved Hide resolved
scripts/spm-integration-test.sh Outdated Show resolved Hide resolved
@hellspawn679
fixed
b736d52 
Signed-off-by: mehul gautam <[email protected]>
@hellspawn679
fixed
95cf12f 
Signed-off-by: mehul gautam <[email protected]>
@hellspawn679 hellspawn679 requested a review from yurishkuro June 21, 2024 18:08
@hellspawn679
fixed
c9d150b 
Signed-off-by: mehul gautam <[email protected]>
@hellspawn679
removed test file
d7f76c9 
Signed-off-by: mehul gautam <[email protected]>
@hellspawn679 hellspawn679 requested a review from yurishkuro June 22, 2024 06:55
yurishkuro
yurishkuro reviewed Jun 22, 2024
View reviewed changes
scripts/spm-integration-test.sh Outdated Show resolved Hide resolved
scripts/spm-integration-test.sh Outdated Show resolved Hide resolved
scripts/spm-integration-test.sh Outdated Show resolved Hide resolved
@hellspawn679
Copy link
Contributor Author

@yurishkuro Also, please take a look at the comments and let me know if there is a change required in them

@hellspawn679 hellspawn679 requested a review from yurishkuro June 24, 2024 17:40
fixed
e9be6c6 
Signed-off-by: mehul gautam <[email protected]>
@hellspawn679 hellspawn679 requested a review from yurishkuro June 24, 2024 18:09
@yurishkuro
clean-up
50ce07a 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro enabled auto-merge (squash) June 24, 2024 21:32
@yurishkuro yurishkuro merged commit be558df into jaegertracing:main Jun 24, 2024
41 checks passed
@yurishkuro yurishkuro mentioned this pull request Jun 29, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlamingSaint FlamingSaint FlamingSaint approved these changes

@yurishkuro yurishkuro yurishkuro approved these changes

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellspawn679 @FlamingSaint @yurishkuro