Skip to content

Commit

Permalink
Fixed unit test
Browse files Browse the repository at this point in the history
Signed-off-by: Rohanraj123 <[email protected]>
  • Loading branch information
Rohanraj123 committed Dec 6, 2024
1 parent 51ab560 commit e40a5f7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
3 changes: 0 additions & 3 deletions cmd/jaeger/config-elasticsearch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ extensions:
backends:
some_storage:
elasticsearch:
rollover:
enabled: true
frequency: "168h"
indices:
index_prefix: "jaeger-main"
spans:
Expand Down
15 changes: 2 additions & 13 deletions plugin/storage/es/factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -297,19 +297,8 @@ func TestConfigurationValidation(t *testing.T) {
wantErr: false,
},
{
name: "missing servers",
cfg: escfg.Configuration{
Rollover: escfg.Rollover{
Enabled: true,
},
},
wantErr: true,
},
{
name: "missing rollover config",
cfg: escfg.Configuration{
Servers: []string{"http://localhost:9200"},
},
name: "missing servers",
cfg: escfg.Configuration{},
wantErr: true,
},
}
Expand Down

0 comments on commit e40a5f7

Please sign in to comment.