Skip to content

Commit

Permalink
Fix command in v2 example (#6134)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
The `component.UseLocalHostAsDefaultHost` gate has been removed from
otel collector since v0.112.0. The example failed to start `jaeger`
because of the invalid argument.

## Description of the changes
- Remove the invalid command line argument.
- Set endpoints for `otlpreceiver` explicitly.

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: haoqixu <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
  • Loading branch information
haoqixu and yurishkuro authored Oct 28, 2024
1 parent cc057a5 commit e327edb
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion examples/hotrod/docker-compose-v2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
services:
jaeger:
image: ${REGISTRY:-}jaegertracing/jaeger:${JAEGER_VERSION:-latest}
command: ["--feature-gates=-component.UseLocalHostAsDefaultHost"]
command:
- --set=receivers.otlp.protocols.grpc.endpoint="0.0.0.0:4317"
- --set=receivers.otlp.protocols.http.endpoint="0.0.0.0:4318"
ports:
- "16686:16686"
- "4317:4317"
Expand Down

0 comments on commit e327edb

Please sign in to comment.