Address Feedback

Signed-off-by: Mahad Zaryab <[email protected]>

cmd/query/app/querysvc/adjuster/adjuster.go

@@ -11,7 +11,6 @@ import (
 
 // Adjuster is an interface for modifying a trace object in place.
 // If an issue is encountered that prevents modifications, an error should be returned.
-// The original trace object is modified directly and not returned.
 // The caller must ensure that all spans in the ptrace.Traces argument
 // belong to the same trace and represent the complete trace.
 type Adjuster interface {

cmd/query/app/querysvc/adjuster/resourceattributes.go

@@ -7,7 +7,7 @@ import (
 	"go.opentelemetry.io/collector/pdata/pcommon"
 	"go.opentelemetry.io/collector/pdata/ptrace"
 
-	"github.com/jaegertracing/jaeger/internal/jotlp"
+	"github.com/jaegertracing/jaeger/internal/jptrace"
 	"github.com/jaegertracing/jaeger/pkg/otelsemconv"
 )
 
@@ -58,7 +58,7 @@ func (ResourceAttributesAdjuster) moveAttributes(span ptrace.Span, resource pcom
 	for k, v := range replace {
 		existing, ok := resource.Attributes().Get(k)
 		if ok && existing.AsRaw() != v.AsRaw() {
-			jotlp.AddWarning(span, "conflicting values between Span and Resource for attribute "+k)
+			jptrace.AddWarning(span, "conflicting values between Span and Resource for attribute "+k)
 			continue
 		}
 		v.CopyTo(resource.Attributes().PutEmpty(k))

cmd/query/app/querysvc/adjuster/resourceattributes_test.go

@@ -9,7 +9,7 @@ import (
 	"github.com/stretchr/testify/require"
 	"go.opentelemetry.io/collector/pdata/ptrace"
 
-	"github.com/jaegertracing/jaeger/internal/jotlp"
+	"github.com/jaegertracing/jaeger/internal/jptrace"
 	"github.com/jaegertracing/jaeger/pkg/otelsemconv"
 )
 
@@ -102,7 +102,7 @@ func TestResourceAttributesAdjuster_SpanWithConflictingLibraryAttributes(t *test
 	require.True(t, ok)
 	require.Equal(t, "Java", val.Str())
 
-	val, ok = resultSpanAttributes.Get(jotlp.WarningsAttribute)
+	val, ok = resultSpanAttributes.Get(jptrace.WarningsAttribute)
 	require.True(t, ok)
 	warnings := val.Slice()
 	require.Equal(t, 1, warnings.Len())

internal/jotlp/package_test.go → internal/jptrace/package_test.go

@@ -1,7 +1,7 @@
 // Copyright (c) 2024 The Jaeger Authors.
 // SPDX-License-Identifier: Apache-2.0
 
-package jotlp
+package jptrace
 
 import (
 	"testing"

internal/jotlp/warning.go → internal/jptrace/warning.go

@@ -1,14 +1,18 @@
 // Copyright (c) 2024 The Jaeger Authors.
 // SPDX-License-Identifier: Apache-2.0
 
-package jotlp
+package jptrace
 
 import (
 	"go.opentelemetry.io/collector/pdata/pcommon"
 	"go.opentelemetry.io/collector/pdata/ptrace"
 )
 
 const (
+	// WarningsAttribute is the name of the span attribute where we can
+	// store various warnings produced from transformations,
+	// such as inbound sanitizers and outbound adjusters.
+	// The value type of the attribute is a string slice.
 	WarningsAttribute = "jaeger.internal.warnings"
 )
 

internal/jotlp/warning_test.go → internal/jptrace/warning_test.go

@@ -1,7 +1,7 @@
 // Copyright (c) 2024 The Jaeger Authors.
 // SPDX-License-Identifier: Apache-2.0
 
-package jotlp
+package jptrace
 
 import (
 	"testing"