Skip to content

Commit

Permalink
[grpc storage]: Propagate tenant to grpc backend (#6030)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Missing tenant information in a gRPC remote backend.

![image](https://github.com/user-attachments/assets/fea54fe0-5785-4225-a8cc-29b705a8be24)


## Description of the changes
Before the gRPC plugins were removed in Jaeger 1.58, tenant information
was distributed in via the internal context.
With this change, the tenant information is also propagated to a removed
grpc backend.

## How was this change tested?
- Manually with jaeger-query, tempo-query and wireshark.

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---

cc @albertteoh do you think we can get this into the next jaeger release
tomorrow? ^^

---------

Signed-off-by: Benedikt Bongartz <[email protected]>
  • Loading branch information
frzifus authored Oct 3, 2024
1 parent d13b943 commit d6631f5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions plugin/storage/grpc/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ func DefaultConfigV2() ConfigV2 {

func (c *Configuration) TranslateToConfigV2() *ConfigV2 {
return &ConfigV2{
Tenancy: c.TenancyOpts,
ClientConfig: configgrpc.ClientConfig{
Endpoint: c.RemoteServerAddr,
TLSSetting: c.RemoteTLS.ToOtelClientConfig(),
Expand Down

0 comments on commit d6631f5

Please sign in to comment.