Skip to content

Commit

Permalink
fix lint
Browse files Browse the repository at this point in the history
Signed-off-by: FlamingSaint <[email protected]>
  • Loading branch information
FlamingSaint committed Jul 22, 2024
1 parent 0aefd7b commit 81bc142
Showing 1 changed file with 4 additions and 17 deletions.
21 changes: 4 additions & 17 deletions cmd/jaeger/internal/extension/jaegerstorage/extension_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import (
"github.com/jaegertracing/jaeger/plugin/storage/memory"
"github.com/jaegertracing/jaeger/storage"
"github.com/jaegertracing/jaeger/storage/dependencystore"
"github.com/jaegertracing/jaeger/storage/metricsstore"
"github.com/jaegertracing/jaeger/storage/spanstore"
)

Expand Down Expand Up @@ -58,22 +57,6 @@ func (e errorFactory) Close() error {
return e.closeErr
}

type errorMetricsFactory struct {
closeErr error
}

func (errorMetricsFactory) Initialize(*zap.Logger) error {
panic("not implemented")
}

func (errorMetricsFactory) CreateMetricsReader() (metricsstore.Reader, error) {
panic("not implemented")
}

func (e errorMetricsFactory) Close() error {
return e.closeErr
}

func TestStorageFactoryBadHostError(t *testing.T) {
_, err := GetStorageFactory("something", componenttest.NewNopHost())
require.ErrorContains(t, err, "cannot find extension")
Expand Down Expand Up @@ -124,6 +107,10 @@ func TestGetFactory(t *testing.T) {
f2, err := GetStorageFactoryV2(name, host)
require.NoError(t, err)
require.NotNil(t, f2)

f3, err := GetMetricsFactory(metricname, host)
require.NoError(t, err)
require.NotNil(t, f3)
}

func TestBadger(t *testing.T) {
Expand Down

0 comments on commit 81bc142

Please sign in to comment.