Skip to content

Commit

Permalink
Revert Returning Interface
Browse files Browse the repository at this point in the history
Signed-off-by: Mahad Zaryab <[email protected]>
  • Loading branch information
mahadzaryab1 committed Dec 18, 2024
1 parent 955ba43 commit 3acab66
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
4 changes: 3 additions & 1 deletion cmd/query/app/querysvc/adjuster/ipattribute.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import (
"go.opentelemetry.io/collector/pdata/ptrace"
)

var _ Adjuster = (*IPAttributeAdjuster)(nil)

var ipAttributesToCorrect = map[string]struct{}{
"ip": {},
"peer.ipv4": {},
Expand All @@ -20,7 +22,7 @@ var ipAttributesToCorrect = map[string]struct{}{
// IPAttribute returns an adjuster that replaces numeric "ip" attributes,
// which usually contain IPv4 packed into uint32, with their string
// representation (e.g. "8.8.8.8"").
func IPAttribute() Adjuster {
func IPAttribute() IPAttributeAdjuster {
return IPAttributeAdjuster{}
}

Expand Down
4 changes: 3 additions & 1 deletion cmd/query/app/querysvc/adjuster/resourceattributes.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import (
"github.com/jaegertracing/jaeger/pkg/otelsemconv"
)

var _ Adjuster = (*ResourceAttributesAdjuster)(nil)

var libraryKeys = map[string]struct{}{
string(otelsemconv.TelemetrySDKLanguageKey): {},
string(otelsemconv.TelemetrySDKNameKey): {},
Expand All @@ -23,7 +25,7 @@ var libraryKeys = map[string]struct{}{
// attributes from spans to the parent resource so that the UI can
// display them separately under Process.
// https://github.com/jaegertracing/jaeger/issues/4534
func ResourceAttributes() Adjuster {
func ResourceAttributes() ResourceAttributesAdjuster {
return ResourceAttributesAdjuster{}
}

Expand Down
4 changes: 3 additions & 1 deletion cmd/query/app/querysvc/adjuster/spanlinks.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@ import (
"go.opentelemetry.io/collector/pdata/ptrace"
)

var _ Adjuster = (*LinksAdjuster)(nil)

// SpanLinks creates an adjuster that removes span links with empty trace IDs.
func SpanLinks() Adjuster {
func SpanLinks() LinksAdjuster {
return LinksAdjuster{}
}

Expand Down

0 comments on commit 3acab66

Please sign in to comment.