Skip to content

Commit

Permalink
Removed No-Op Test
Browse files Browse the repository at this point in the history
Signed-off-by: Wise-Wizard <[email protected]>
  • Loading branch information
Wise-Wizard committed Jun 27, 2024
1 parent 0a24e87 commit 362ea74
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions internal/metrics/otelmetrics/factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.opentelemetry.io/otel/exporters/prometheus"
"go.opentelemetry.io/otel/metric/noop"
sdkmetric "go.opentelemetry.io/otel/sdk/metric"

"github.com/jaegertracing/jaeger/internal/metrics/otelmetrics"
Expand Down Expand Up @@ -122,7 +121,6 @@ func TestNamespace(t *testing.T) {
require.NotNil(t, counter)
counter.Inc(1)


testCounter := findMetric(t, registry, "namespace_test_counter_total")

metrics := testCounter.GetMetric()
Expand All @@ -147,13 +145,3 @@ func TestNormalization(t *testing.T) {
metrics := testGauge.GetMetric()
assert.Equal(t, float64(1), metrics[0].GetGauge().GetValue())
}

func TestNoopMeterProvider(t *testing.T) {
noOpFactory := otelmetrics.NewFactory(noop.NewMeterProvider())
counter := noOpFactory.Counter(metrics.Options{
Name: "noop_counter",
Tags: map[string]string{"tag1": "value1"},
})
require.NotNil(t, counter)
counter.Inc(1)
}

0 comments on commit 362ea74

Please sign in to comment.