Skip to content

Commit

Permalink
Change Return Type of Factory Adapter And Implement Depstore Factory
Browse files Browse the repository at this point in the history
Signed-off-by: Mahad Zaryab <[email protected]>
  • Loading branch information
mahadzaryab1 committed Dec 6, 2024
1 parent 2fb8fc8 commit 1ce9ffe
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion storage_v2/factoryadapter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,15 @@ import (
"io"

storage_v1 "github.com/jaegertracing/jaeger/storage"
"github.com/jaegertracing/jaeger/storage_v2/depstore"
"github.com/jaegertracing/jaeger/storage_v2/tracestore"
)

type Factory struct {
ss storage_v1.Factory
}

func NewFactory(ss storage_v1.Factory) tracestore.Factory {
func NewFactory(ss storage_v1.Factory) *Factory {
return &Factory{
ss: ss,
}
Expand Down Expand Up @@ -51,3 +52,8 @@ func (f *Factory) CreateTraceWriter() (tracestore.Writer, error) {
}
return NewTraceWriter(spanWriter), nil
}

// CreateDependencyReader implements depstore.Factory.
func (f *Factory) CreateDependencyReader() (depstore.Reader, error) {
return f.ss.CreateDependencyReader()
}

0 comments on commit 1ce9ffe

Please sign in to comment.