Skip to content

Commit

Permalink
Change start/end time to non-nullable (#109)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Part of jaegertracing/jaeger#4150

## Description of the changes
- Make time values non-nullable to avoid pointers

## How was this change tested?
- In jaegertracing/jaeger#6218

---------

Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
yurishkuro authored Nov 17, 2024
1 parent 29ed41a commit 7728794
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
4 changes: 3 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Copyright (c) 2023 The Jaeger Authors.
# SPDX-License-Identifier: Apache-2.0

THRIFT_VER?=0.13
THRIFT_VER?=0.19
THRIFT_IMG?=jaegertracing/thrift:$(THRIFT_VER)
THRIFT=docker run --rm -u $(shell id -u) -v "${PWD}:/data" $(THRIFT_IMG) thrift

Expand Down
6 changes: 4 additions & 2 deletions proto/api_v2/query.proto
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,13 @@ message GetTraceRequest {
];
// Optional. The start time to search trace ID.
google.protobuf.Timestamp start_time = 2 [
(gogoproto.stdtime) = true
(gogoproto.stdtime) = true,
(gogoproto.nullable) = false
];
// Optional. The end time to search trace ID.
google.protobuf.Timestamp end_time = 3 [
(gogoproto.stdtime) = true
(gogoproto.stdtime) = true,
(gogoproto.nullable) = false
];
}

Expand Down
6 changes: 4 additions & 2 deletions proto/api_v3/query_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ message GetTraceRequest {
string trace_id = 1;
// Optional. The start time to search trace ID.
google.protobuf.Timestamp start_time = 2 [
(gogoproto.stdtime) = true
(gogoproto.stdtime) = true,
(gogoproto.nullable) = false
];
// Optional. The end time to search trace ID.
google.protobuf.Timestamp end_time = 3 [
(gogoproto.stdtime) = true
(gogoproto.stdtime) = true,
(gogoproto.nullable) = false
];
}

Expand Down

0 comments on commit 7728794

Please sign in to comment.