This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 94
add compileInsertGetId and processInsertGetId method #15
Open
donnykurnia
wants to merge
6
commits into
jacquestvanzuydam:5.1-support
Choose a base branch
from
donnykurnia:5.1-support
base: 5.1-support
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add compileInsertGetId and processInsertGetId method #15
donnykurnia
wants to merge
6
commits into
jacquestvanzuydam:5.1-support
from
donnykurnia:5.1-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resGrammar and PostgresProcessor classes as-is I've check it in my project using php artisan tinker and it's working well PS: this library need tests to make sure all methods working well Signed-off-by: Donny Kurnia <[email protected]>
PS: This approach assume that the tables already have generator and trigger set for the id column. |
nice approach, assuming that the tables that are using generator / sequence will be with trigger, I think this solves our problems |
It works for Laravel 5.2? |
@jessesantos my fork only tested for laravel 5.1, because my project still use it for now. |
Does it work with PHP7? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taken from PostgresGrammar and PostgresProcessor classes as-is
I've check it in my project using php artisan tinker and it's working well
PS: this library need tests to make sure all methods working well
Signed-off-by: Donny Kurnia [email protected]