Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CollectExactlyOneRow function #1720

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Add CollectExactlyOneRow function #1720

merged 2 commits into from
Aug 19, 2023

Conversation

MartyHub
Copy link
Contributor

Hello,

this is a PR for #1411

Thanks and regards

@jackc
Copy link
Owner

jackc commented Aug 19, 2023

TestCollectExactlyOneRowExtraRows is failing because it is not expecting the first row when there is an error because of multiple rows found.

I think the behavior the test is expecting is actually preferable -- no data result on error.

@MartyHub
Copy link
Contributor Author

OK, sorry, I'll correct my last commit!

@jackc jackc merged commit 3899313 into jackc:master Aug 19, 2023
14 checks passed
@jackc
Copy link
Owner

jackc commented Aug 19, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants