Fix issue with cycling panes in edit_with_instructions #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Fixes jackMort#352 Closes jackMort#352 Something in 1f69ba2 broke this - here's a fix for it. For some reason the active_panel is coming up nil when the view initially opens. It's being set at the top, but something is overwriting it.
jackMort
approved these changes
Feb 5, 2024
aaronik
added a commit
to aaronik/ChatGPT.nvim
that referenced
this pull request
Feb 6, 2024
The previous fix (jackMort#388) worked _only for the first time the edit with instructions window was opened_. Now it works every time it's opened (at least up to however many times I tested it. Theoretically it could fail on the 10,000th time.)
aaronik
added a commit
to aaronik/ChatGPT.nvim
that referenced
this pull request
Feb 6, 2024
The previous fix (jackMort#388) worked _only for the first time the edit with instructions window was opened_. Now it works every time it's opened (at least up to however many times I tested it. Theoretically it could fail on the 10,000th time.)
Merged
aaronik
added a commit
to aaronik/ChatGPT.nvim
that referenced
this pull request
Feb 6, 2024
The previous fix (jackMort#388) worked _only for the first time the edit with instructions window was opened_. Now it works every time it's opened (at least up to however many times I tested it. Theoretically it could fail on the 10,000th time.)
aaronik
added a commit
to aaronik/ChatGPT.nvim
that referenced
this pull request
Feb 6, 2024
The previous fix (jackMort#388) worked _only for the first time the edit with instructions window was opened_. Now it works every time it's opened (at least up to however many times I tested it. Theoretically it could fail on the 10,000th time.)
aaronik
added a commit
to aaronik/ChatGPT.nvim
that referenced
this pull request
Feb 6, 2024
The previous fix (jackMort#388) worked _only for the first time the edit with instructions window was opened_. Now it works every time it's opened (at least up to however many times I tested it. Theoretically it could fail on the 10,000th time.)
aaronik
added a commit
to aaronik/ChatGPT.nvim
that referenced
this pull request
Feb 7, 2024
The previous fix (jackMort#388) worked _only for the first time the edit with instructions window was opened_. Now it works every time it's opened (at least up to however many times I tested it. Theoretically it could fail on the 10,000th time.)
jackMort
pushed a commit
that referenced
this pull request
Feb 25, 2024
The previous fix (#388) worked _only for the first time the edit with instructions window was opened_. Now it works every time it's opened (at least up to however many times I tested it. Theoretically it could fail on the 10,000th time.)
Wezea
pushed a commit
to Wezea/ChatGPT.nvim
that referenced
this pull request
Apr 20, 2024
This Fixes jackMort#352 Closes jackMort#352 Something in 1f69ba2 broke this - here's a fix for it. For some reason the active_panel is coming up nil when the view initially opens. It's being set at the top, but something is overwriting it.
Wezea
pushed a commit
to Wezea/ChatGPT.nvim
that referenced
this pull request
Apr 20, 2024
The previous fix (jackMort#388) worked _only for the first time the edit with instructions window was opened_. Now it works every time it's opened (at least up to however many times I tested it. Theoretically it could fail on the 10,000th time.)
qaptoR
pushed a commit
to qaptoR-nvim/ChatGPT.nvim
that referenced
this pull request
Jul 6, 2024
The previous fix (jackMort#388) worked _only for the first time the edit with instructions window was opened_. Now it works every time it's opened (at least up to however many times I tested it. Theoretically it could fail on the 10,000th time.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fixes #352
Closes #352
Something in 1f69ba2 broke this - here's a fix for it.
For some reason the active_panel is coming up nil when the view initially opens. It's being set at the top, but something is overwriting it.