Enable use with both available python XDG modules #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently two python modules implementing the freedesktop.org standards, PyXDG https://freedesktop.org/wiki/Software/pyxdg/ and xdg https://github.com/srstevenson/xdg. Unfortunately both are imported under the namespace `xdg`. This patch enables either module to be used to return the required directory paths.
dsheeler
requested changes
Oct 12, 2021
There was a problem hiding this comment.
This actually doesn't work for me in the case of only having pyxdg installed. I get this:
$ jack_mixer
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/jack_mixer/gui.py", line 29, in <module>
confdir = xdg.XDG_CONFIG_HOME / "jack_mixer"
AttributeError: module 'xdg' has no attribute 'XDG_CONFIG_HOME'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/bin/jack_mixer", line 5, in <module>
from jack_mixer.app import main
File "/usr/lib/python3.9/site-packages/jack_mixer/app.py", line 27, in <module>
from . import gui
File "/usr/lib/python3.9/site-packages/jack_mixer/gui.py", line 32, in <module>
confdir = xdg.BaseDirectory.save_config_path("jack_mixer")
AttributeError: module 'xdg' has no attribute 'BaseDirectory'
I noticed BaseDirectory is not exported at the top level or something weird. It works if you do from xdg import BaseDirectory and use it as BaseDirectory. Can't say I understand why!
|
We should Given that, I don't think this PR is useful. @markk Thanks for your interest in jack_mixer and your work nevertheless. A PR replacing |
|
Thanks. I've made a new pull request #149 for the appdirs module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently two python modules implementing the freedesktop.org
standards, PyXDG https://freedesktop.org/wiki/Software/pyxdg/ and xdg
https://github.com/srstevenson/xdg. Unfortunately both are imported under the
namespace
xdg.This patch enables either module to be used to return the required directory
paths.