Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pipenv with uv #509

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Replace pipenv with uv #509

merged 4 commits into from
Sep 16, 2024

Conversation

cgtobi
Copy link
Collaborator

@cgtobi cgtobi commented Sep 16, 2024

Summary by Sourcery

Replace pipenv with uv for dependency management and update the README accordingly. Enhance the CI configuration by adding Python 3.12.5 to the testing matrix. Update pre-commit hooks to newer versions and remove the setup.cfg file.

Enhancements:

  • Update pre-commit hooks to use newer versions of ruff and mypy.

CI:

  • Add Python 3.12.5 to the testing matrix in the GitHub Actions workflow.

Documentation:

  • Update README to replace pipenv installation instructions with uv.

Chores:

  • Remove the setup.cfg file from the repository.

@cgtobi cgtobi requested a review from jabesq as a code owner September 16, 2024 13:53
Copy link

sourcery-ai bot commented Sep 16, 2024

Reviewer's Guide by Sourcery

This pull request replaces pipenv with uv for dependency management, updates some dependencies, and makes minor changes to CI workflows. The changes aim to modernize the project's tooling and expand Python version support.

File-Level Changes

Change Details Files
Replace pipenv with uv for dependency management
  • Remove pipenv installation command
  • Add uv sync command for installing dependencies
README.md
Update dependencies and pre-commit hooks
  • Update ruff-pre-commit from v0.6.1 to v0.6.4
  • Update mypy from v1.11.1 to v1.11.2
.pre-commit-config.yaml
Expand Python version support in CI
  • Add Python 3.12.5 to the test matrix
.github/workflows/pythonpackage.yml
Remove unused configuration and comments
  • Remove commented-out section for publishing to Test PyPI
  • Delete setup.cfg file
.github/workflows/publish-to-pypi.yml
setup.cfg

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cgtobi - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 2 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@cgtobi cgtobi force-pushed the replace_pipenv_with_uv branch from e4a58e3 to d0bf788 Compare September 16, 2024 13:57
@cgtobi cgtobi merged commit 042724e into development Sep 16, 2024
6 checks passed
@cgtobi cgtobi deleted the replace_pipenv_with_uv branch September 16, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant