Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bticino #486

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Update bticino #486

merged 2 commits into from
Jan 13, 2024

Conversation

cgtobi
Copy link
Collaborator

@cgtobi cgtobi commented Jan 13, 2024

The pull request introduces enhancements to the Netatmo integration by adding support for new device types, specifically a centralized ventilation controller (NLLF) and a controlled socket (BNCS). It includes updates to the device categorization, module inheritance, and the addition of a new FanSpeedMixin to handle fan speed data. The PR also includes updates to the test suite to cover the new functionality.

@cgtobi cgtobi requested a review from jabesq as a code owner January 13, 2024 20:46
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request introduces enhancements to the Netatmo integration by adding support for new device types, specifically a centralized ventilation controller (NLLF) and a controlled socket (BNCS). It includes updates to the device categorization, module inheritance, and the addition of a new FanSpeedMixin to handle fan speed data. The PR also includes updates to the test suite to cover the new functionality.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that the newly introduced fan speed range is intentional and adequately documented, as it currently only allows for two discrete speeds. If this range is likely to change or if there are more than two valid speeds, consider using constants or a configuration setting for these values.
  • Review the naming conventions and documentation for the new classes and mixins to ensure they are consistent with the rest of the codebase and clearly convey their purpose.
  • Verify that the changes made to the test suite comprehensively cover the new functionality and that the tests are passing as expected.

Your trial expires on January 15, 2024. Please email [email protected] to continue using Sourcery ✨

Did you find the review useful? React with a 👍 or 👎 to each comment

src/pyatmo/modules/module.py Show resolved Hide resolved
@cgtobi cgtobi merged commit 62e6b30 into development Jan 13, 2024
5 checks passed
@cgtobi cgtobi deleted the update_bticino branch January 13, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant