Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicates in entity names #482

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix duplicates in entity names #482

merged 1 commit into from
Dec 22, 2023

Conversation

cgtobi
Copy link
Collaborator

@cgtobi cgtobi commented Dec 22, 2023 •
edited
Loading

@cgtobi cgtobi requested a review from jabesq as a code owner December 22, 2023 14:26
sourcery-ai[bot]
sourcery-ai bot reviewed Dec 22, 2023
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has expired. Please email [email protected] to continue using Sourcery ✨

@cgtobi cgtobi merged commit b49a3bb into development Dec 22, 2023
6 checks passed
@cgtobi cgtobi deleted the fix_name_spam branch December 22, 2023 14:36
@zufivan
Copy link

zufivan commented Dec 23, 2023

thanks @cgtobi
i tested "fix_name_spam" it's working but I have this litlle problem:

my main module is called camera_padronale
my second module is called camera_bimbi
my third module is called sala

the entities created now (for temperature) is :
sensor.camera_padronale_temperature (OK)
sensor.camera_padronale_bimbi_temperature (NOK) it should be sensor.camera_padronale_camera_bimbi_temperature
sensor.camera_padronale_sala_temperature (OK)

@cgtobi
Copy link
Collaborator Author

cgtobi commented Dec 23, 2023

Thanks for testing. I'll take a look at how to approach that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@jabesq jabesq Awaiting requested review from jabesq jabesq is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgtobi @zufivan