Clean up #479
Merged
Clean up #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Refactoring
PR Summary: The pull request introduces a change in the 'fix_id' function within the 'helpers.py' module. It modifies the condition that checks for the presence of the '_id' key in a dictionary representing a station. The new condition uses the 'get' method to safely access the '_id' key and proceeds only if the key is not present or its value is None.
General suggestions:
- Ensure that the change in behavior is intentional. The new condition will treat stations with '_id' explicitly set to None differently than before. If the previous behavior should be preserved, consider adjusting the condition to check for both the absence of '_id' and its value being None.
- The PR title 'Clean up' is quite generic. It would be beneficial to provide a more descriptive title that reflects the specific nature of the changes made, such as 'Refactor _id presence check in fix_id function'.
- A brief PR description explaining the rationale behind the change and its impact on the codebase would help reviewers understand the context and the intent of the refactoring.
Your trial expires on December 16, 2023. Please email [email protected] to continue using Sourcery ✨
| @@ -19,7 +19,7 @@ def fix_id(raw_data: RawData) -> dict[str, Any]: | |||
| for station in raw_data: | |||
| if not isinstance(station, dict): | |||
| continue | |||
| if "_id" not in station: | |||
| if station.get("_id") is None: | |||
There was a problem hiding this comment.
question (llm): The change from direct key access to using get is safer in terms of avoiding a KeyError, but it changes the behavior. Previously, if '_id' was present but set to None, it would not continue, but now it will. Ensure this behavior change is intentional and correct.
cgtobi
added a commit
that referenced
this pull request
Dec 15, 2023
* cd: Run publish-to-test-pypi only on development branch * fix devcontainer (#468) * Add start and end times to room class (#469) * Remove deprecated code (#461) * Remove deprecated code * Remove old codeql config * Remove unused fixture * Minor clean up * Refactor async_post_request Signed-off-by: Tobias Sauerwein <[email protected]> --------- Signed-off-by: Tobias Sauerwein <[email protected]> * Split tests and clean up (#471) * split tests * clean up cruft * Fix NLPD to provide energy readings * Add BNLD - Bticino dimmable light * Update readme (#472) * Clean up somfy shutter * Add new bticino scope * update readme * chore(deps): Bump actions/setup-python from 4.7.1 to 5.0.0 (#474) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.1 to 5.0.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.7.1...v5.0.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add missing device type mapping for NIS (#476) * Add power data to NLPD entities (#477) * Clean up (#479) --------- Signed-off-by: Tobias Sauerwein <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Hugo Dupras <[email protected]> Co-authored-by: deosrc <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
cgtobi
added a commit
that referenced
this pull request
Dec 20, 2023
* cd: Run publish-to-test-pypi only on development branch * fix devcontainer (#468) * Add start and end times to room class (#469) * Remove deprecated code (#461) * Remove deprecated code * Remove old codeql config * Remove unused fixture * Minor clean up * Refactor async_post_request Signed-off-by: Tobias Sauerwein <[email protected]> --------- Signed-off-by: Tobias Sauerwein <[email protected]> * Split tests and clean up (#471) * split tests * clean up cruft * Fix NLPD to provide energy readings * Add BNLD - Bticino dimmable light * Update readme (#472) * Clean up somfy shutter * Add new bticino scope * update readme * chore(deps): Bump actions/setup-python from 4.7.1 to 5.0.0 (#474) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.1 to 5.0.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.7.1...v5.0.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add missing device type mapping for NIS (#476) * Add power data to NLPD entities (#477) * Clean up (#479) * Update CHANGELOG.md * Fix nlfe (#480) * Add missing NLFE Legrand dimmer switch * clean up * Update changelog --------- Signed-off-by: Tobias Sauerwein <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Hugo Dupras <[email protected]> Co-authored-by: deosrc <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.