Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 3.8 #450

Merged
merged 2 commits into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish-to-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Set up Python 3.8
- name: Set up Python 3.9
uses: actions/[email protected]
with:
python-version: 3.8
python-version: 3.9
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-to-test-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
with:
ref: development
fetch-depth: 0
- name: Set up Python 3.8
- name: Set up Python 3.9
uses: actions/[email protected]
with:
python-version: 3.8
python-version: 3.9
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
max-parallel: 1
matrix:
python-version: [3.10.8]
python-version: [3.9]

steps:
- uses: actions/checkout@v4
Expand All @@ -39,7 +39,7 @@ jobs:
strategy:
max-parallel: 4
matrix:
python-version: [3.10.8]
python-version: [3.9]

steps:
- uses: actions/checkout@v4
Expand All @@ -63,7 +63,7 @@ jobs:
strategy:
max-parallel: 4
matrix:
python-version: [3.8, 3.9, 3.10.8]
python-version: [3.9, 3.10.8, 3.11.4]

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ repos:
rev: v3.14.0
hooks:
- id: pyupgrade
args: [--py38-plus]
args: [--py39-plus]
exclude: "external_src/int-tools"

- repo: https://github.com/asottile/add-trailing-comma
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ pyatmo
[![PyPi](https://img.shields.io/pypi/v/pyatmo.svg)](https://pypi.python.org/pypi/pyatmo)
[![license](https://img.shields.io/pypi/l/pyatmo.svg)](https://github.com/jabesq/pyatmo/blob/master/LICENSE.txt)

> **Warning:**
> **Warning:**
> Due to personal reasons, I am currently unable to dedicate sufficient time to effectively manage this repository. Consequently, no attention will be given to existing or forthcoming issues until further notice. **However**, I want to assure you that I will continue to merge any pull requests that are submitted, provided they successfully pass the continuous integration tests and do not exhibit any glaring issues.
>
> I apologize for any inconvenience this may cause, and I sincerely hope to have the capacity to allocate more time to this repository in the near future. Your understanding is greatly appreciated.
Expand Down Expand Up @@ -72,4 +72,4 @@ Another way to run the tests is by using `tox`. This runs the tests against the

or by specifying a python version

tox -e py38
tox -e py39
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = ["wheel", "setuptools", "attrs>=17.1"]
build-backend = "setuptools.build_meta"

[tool.pytest.ini_options]
minversion = "6.0"
minversion = "7.0"
asyncio_mode = "auto"

[tool.setuptools_scm]
Expand Down
3 changes: 1 addition & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ classifiers =
License :: OSI Approved :: MIT License
Programming Language :: Python :: 3
Programming Language :: Python :: 3 :: Only
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Expand All @@ -28,7 +27,7 @@ install_requires =
oauthlib~=3.1
requests~=2.24
requests-oauthlib~=1.3
python_requires = >=3.8
python_requires = >=3.9
include_package_data = True
package_dir = =src
setup_requires =
Expand Down
2 changes: 1 addition & 1 deletion src/pyatmo/camera.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Support for Netatmo security devices (cameras, smoke detectors, sirens, window sensors, events and persons)."""
from __future__ import annotations

import imghdr
import imghdr # pylint: disable=deprecated-module
import time
from abc import ABC
from collections import defaultdict
Expand Down
6 changes: 3 additions & 3 deletions src/pyatmo/const.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Common constants."""
from __future__ import annotations

from typing import Any, Dict
from typing import Any

ERRORS: dict[int, str] = {
400: "Bad request",
Expand All @@ -15,7 +15,7 @@
}

# Special types
RawData = Dict[str, Any]
RawData = dict[str, Any]

DEFAULT_BASE_URL: str = "https://api.netatmo.com/"

Expand Down Expand Up @@ -51,7 +51,7 @@
AUTHORIZATION_HEADER = "Authorization"

# Possible scops
ALL_SCOPES = [
ALL_SCOPES: list[str] = [
"access_camera", # Netatmo camera products
"access_doorbell", # Netatmo Smart Video Doorbell
"access_presence", # Netatmo Smart Outdoor Camera
Expand Down
3 changes: 2 additions & 1 deletion src/pyatmo/modules/base_class.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@

import logging
from abc import ABC
from collections.abc import Iterable
from dataclasses import dataclass
from typing import TYPE_CHECKING, Any, Iterable
from typing import TYPE_CHECKING, Any

from pyatmo.const import RawData
from pyatmo.modules.device_types import DeviceType
Expand Down
4 changes: 2 additions & 2 deletions src/pyatmo/modules/module.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import logging
from datetime import datetime
from enum import Enum
from typing import TYPE_CHECKING, Any, Dict
from typing import TYPE_CHECKING, Any

from aiohttp import ClientConnectorError

Expand All @@ -19,7 +19,7 @@

LOG = logging.getLogger(__name__)

ModuleT = Dict[str, Any]
ModuleT = dict[str, Any]

# Hide from features list
ATTRIBUTE_FILTER = {
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
[tox]
envlist = py38,py39,py310
envlist = py39,py310,py311
isolated_build = True
skip_missing_interpreters = True

[gh-actions]
python =
3.8: py38
3.9: py39
3.10: py310
3.11: py311

[testenv]
deps =
Expand Down