Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add extracgin options from z.array(z.enum([]) and z.enum([])… #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bartoszgolebiowski
Copy link

….array() via useEnumValues hook

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-ts-form ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 7:39pm

Copy link
Collaborator

@scamden scamden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm! one nit mentioned

@@ -16,7 +16,8 @@ export function parseDescription(description?: string) {
};
}

export function getEnumValues(type: RTFSupportedZodTypes) {
export function getEnumValues(type: RTFSupportedZodTypes): readonly string[] | undefined {
if (type._def.typeName === z.ZodFirstPartyTypeKind.ZodArray) return getEnumValues(type._def.type)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think type.element is preferred here

@Seanmclem
Copy link

why was this not merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants