Skip to content

Commit

Permalink
ci(github): add type job
Browse files Browse the repository at this point in the history
  • Loading branch information
ivangabriele committed Oct 1, 2023
1 parent 94f0991 commit ad0342c
Show file tree
Hide file tree
Showing 5 changed files with 32 additions and 226 deletions.
29 changes: 29 additions & 0 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,35 @@ name: Check
on: push

jobs:
type:
name: Type
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Setup Python
uses: actions/setup-python@v4
with:
python-version: "3.10"

- name: Install Poetry
uses: snok/install-poetry@v1
with:
version: "1.6.1"

- name: Install mypy
run: pip install ;ypy

- name: Install dependencies
run: poetry install

# - name: Setup Types
# run: mypy --install-types --non-interactive

- name: Check Types
run: make test

test:
name: Unit Test
runs-on: ubuntu-latest
Expand Down
21 changes: 0 additions & 21 deletions agents/product_owner.py
Original file line number Diff line number Diff line change
@@ -1,21 +1,11 @@
import select
from typing import TYPE_CHECKING
from autogen import AssistantAgent
from agents.base_agent import BaseAgent
from constants import COMMON_LLM_CONFIG

from utils import clean_text


if TYPE_CHECKING:
from autogen import UserProxyAgent
from agents.software_engineer import SoftwareEngineer


class ProductOwner(BaseAgent):
ceo_user_proxy_agent: "UserProxyAgent"
software_engineer: "SoftwareEngineer"

def __init__(self) -> None:
self.is_product_owner = True

Expand Down Expand Up @@ -45,14 +35,3 @@ def __init__(self) -> None:
"""
),
)

def attach_agents(
self,
software_engineer: "SoftwareEngineer",
):
self.software_engineer = software_engineer

def ask_software_engineer(self, message: str):
return self.software_engineer.ask(
sender=self.as_assistant_agent, message=message
)
2 changes: 2 additions & 0 deletions mypy.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

[mypy-autogen.*]
ignore_missing_imports = True
[mypy-dacite.*]
ignore_missing_imports = True
[mypy-jsonc_parser.*]
ignore_missing_imports = True
[mypy-IPython.*]
Expand Down
205 changes: 1 addition & 204 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ jsonc-parser = "^1.1.5"
dacite = "^1.8.1"

[tool.poetry.group.dev.dependencies]
mypi = "^0.0.3"
pytest = "^7.4.2"
types-beautifulsoup4 = "^4.12.0.6"
types-requests = "^2.31.0.7"
Expand Down

0 comments on commit ad0342c

Please sign in to comment.