Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ground truth for dataframe ground truth #16

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dyt811
Copy link
Member

@dyt811 dyt811 commented Dec 20, 2021

With multi-sessions and multi-contrasts support, we can pickup ground truth from unspecified modalities to use to help salvage more participant data

Updating the df_test and df_multi correspondingly to include potential additional ground truth being picked up.

Also update documentation about the missing df_multi CSV.

@dyt811 dyt811 self-assigned this Dec 20, 2021
@mariehbourget
Copy link
Member

mariehbourget commented Jan 16, 2022

Hi @dyt811!
I saw that you removed the df_ref_multi.csv and the corresponding test in ivadomed/ivadomed#1044. I'm wondering why as it is used for testing the bids dataframe with a list of path in path_data which I don't think is covered by your new tests.

@dyt811
Copy link
Member Author

dyt811 commented Jan 16, 2022

Yeah, it was a mistake. Being reverted back just now. This PR will be updated too. Currently using a separate release from a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants