-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New loader integration: update datasets #13
Conversation
This PR is ready for review, it adds new file to test the new loader and ct-scan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! My only comment/concern is that I am wondering if only one subject will be enough for testing. It depends on the tests we plan to add, but with a single subject we can't do a training (we need at least 1 subject for training and 1 for validation). If that's not a test you planned to add, you can ignore this comment!
Thanks @andreanne-lemay for the review. I only want to test the force_index in the BidsDataframe. For training, we can test with MRI because they are nifti files as well. |
Related to #5.
This PR aims to update
MRI anat
andmicroscopy_png
datasets following the integration of the new loader in ivadomed.It also includes a small
ct-scan
dataset to test the file indexing from the decathlon spleen dataset used under CC-BY-SA 4.0 license.