chore: odyssey_sendTransaction
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Oct 18, 2024
rkdud007
changed the title
wallet_odyssey_sendTransactionodyssey_sendTransaction
jenpaff
reviewed
Oct 21, 2024
jenpaff
reviewed
Oct 21, 2024
jenpaff
reviewed
Oct 21, 2024
|
@klkvr i think there might be an issue with the e2e tests, the error seems unrelated to the changes in the PR https://github.com/ithacaxyz/odyssey/actions/runs/11443207043/job/31851962427?pr=56 |
|
oh sorry, should be fine after #63 |
jenpaff
approved these changes
Oct 22, 2024
onbjerg
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolving #50
wallet_sendTransactiontowallet_odyssey_sendTransactionnote: personally fan of
<namespace>_odyssey_*as this contains eip's suggestionwallet_sendTransactionedit: q. saw foundry PR have alias
odyssey_sendTransactionmaybe i should match into the one?