feat: e2e tests with kurtosis #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
reviewed
Oct 17, 2024
onbjerg
reviewed
Oct 17, 2024
crates/testing/src/tests.rs
Outdated
| use url::Url; | ||
|
|
||
| static REPLICA_RPC: LazyLock<Url> = LazyLock::new(|| { | ||
| std::env::var("REPLICA_RPC") |
There was a problem hiding this comment.
i'm wondering if we could just skip the tests instead of failing them when u run these locally, not particularly great ux running cargo test and having them fail :( same issue in foundry. not a blocker though
onbjerg
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds github workflow which launches kurtosis and runs (for now 2 simple) tests against running network.
This is for now patched to use my repo for optimism-package until we have paradigmxyz/optimism-package#4 merged.
Here's example workflow run https://github.com/klkvr/odyssey/actions/runs/11372561760/job/31637163326
I wasn't able to make docker caching work so right now it takes ~30m, I'm wondering if there are some easy optimizations we could do?