Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set from field when estimating gas #37

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: set from field when estimating gas #37

merged 1 commit into from
Oct 15, 2024

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Oct 15, 2024

In some cases tx.origin might be checked, so we should set from in the request, otherwise these calls revert

@onbjerg onbjerg added the C-bug Something isn't working label Oct 15, 2024
@onbjerg onbjerg merged commit 811f874 into main Oct 15, 2024
13 checks passed
@onbjerg onbjerg deleted the onbjerg/estimate-gas-fix branch October 15, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
C-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@onbjerg