Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:: optimize Gas Estimation and Fee Calculation using tokio::join! #32

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

malik672
Copy link
Contributor

@malik672 malik672 commented Oct 13, 2024

This PR improves the performance of gas estimation and fee calculation by running both tasks concurrently using tokio::join!. This change reduces the overall execution time by allowing the two independent operations to proceed in parallel, rather than sequentially

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title and description to describe what the PR does:)

@malik672 malik672 changed the title chore:: nits chore:: optimize Gas Estimation and Fee Calculation using tokio::join! Oct 14, 2024
@malik672 malik672 requested a review from onbjerg October 14, 2024 00:37
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs a run of cargo +nightly fmt --all:)

@malik672 malik672 requested a review from onbjerg October 14, 2024 00:48
@onbjerg onbjerg merged commit aff5101 into ithacaxyz:main Oct 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants