Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor fork handling and optimize revm_spec function #30

Closed
wants to merge 1 commit into from

Conversation

malik672
Copy link
Contributor

I mean my idea is that forks won't decrease but increase and we will still have to support them, so instead of changing them later we can just optimize for them now

@onbjerg
Copy link
Member

onbjerg commented Oct 13, 2024

As mentioned in the issue I don't think this is the way to go, I appreciate your contribution nonetheless:)

@onbjerg onbjerg closed this Oct 13, 2024
@Houseofkholin
Copy link

Houseofkholin commented Oct 13, 2024

Saw your

As mentioned in the issue I don't think this is the way to go, I appreciate your contribution nonetheless:)

Saw your other comment and I agree btw I wanted to propose to use an fxhashmap rather than tree in the first place tbh I didn’t just want to add anymore dependency, I just thought there should be a better way to handle it than the if/else performant wise(will still find it btw). I will probably find it and run some benchmark on it also, if I find a more efficient way can I include a benchmark in the code base ?

I’m still @malik672 just had to create this acc since I’m outside and don’t have access to my acc

@malik672 malik672 deleted the fork branch October 13, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants