chore: prepare 94.0.0 release

CHANGELOG.md

@@ -5,6 +5,18 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org). Except add new
 rule (it is breaking changed by default).
 
+## 94.0.0 - 2018-12-11
+
+- Changed: move `unicorn` rules into `esnext` preset.
+- Changed: remove `sourceType` from `react` preset.
+- Changed: remove `es6` from `jest` preset.
+- Changed: remove `es6` from `ava` preset.
+- Changed: remove `es6` from `html` preset.
+- Fixed: add `jest/globals` to `jest` preset.
+- Removed: `globals` from `react` preset.
+- Removed: `es5` preset (use `babel` to transpile code in `es5`/`es3` and etc).
+- Removed: `core` preset.
+
 ## 93.0.0 - 2018-12-11
 
 - Added: `react/forbid-foreign-prop-types` rule.

README.md

@@ -57,15 +57,7 @@ React-specific rules to those in the ESNext config):
 
 ```json
 {
-  "extends": "plugin:itgalaxy/react"
-}
-```
-
-If working on an ES5 project, extend the ES5 version of the configuration:
-
-```json
-{
-  "extends": "plugin:itgalaxy/es5"
+  "extends": ["plugin:itgalaxy/esnext", "plugin:itgalaxy/react"]
 }
 ```
 
@@ -80,25 +72,17 @@ following configuration file:
     "plugin:itgalaxy/esnext",
     "plugin:itgalaxy/react",
     "plugin:itgalaxy/lodash",
-    "plugin:itgalaxy/mocha"
+    "plugin:itgalaxy/jest"
   ]
 }
 ```
 
-Notice: presets **"plugin:itgalaxy/esnext"** or **"plugin:itgalaxy/es5"** always should be **first**.
+Notice: presets **"plugin:itgalaxy/esnext"** should be **first**.
 
 ## Provided configurations
 
 This plugin provides the following core configurations:
 
-- [es5](lib/config/es5.js): Use this for legacy projects.
-
-```json
-{
-  "extends": ["plugin:itgalaxy/es5"]
-}
-```
-
 - [esnext](lib/config/esnext.js): Use this for anything written with ES2015+ features.
 
 ```json
@@ -145,7 +129,7 @@ module.exports = {
 };
 ```
 
-- [node](lib/config/node.js): Use this for nodejs projects.
+- [node](lib/config/node.js): Use this for `nodejs` projects.
 
 Example:
 
@@ -155,7 +139,7 @@ Example:
 }
 ```
 
-- [react](lib/config/react.js): Use this for React projects.
+- [react](lib/config/react.js): Use this for `React` projects.
 
 Example:
 
@@ -167,8 +151,6 @@ Example:
 
 - [all](lib/config/all.js): Don't use. It is for internal purposes (testings and tools).
 
-- [core](lib/config/core.js): Don't use. It is for internal purposes (testings and tools).
-
 This plugin also provides the following tool-specific configurations, which can be used on top of the core configurations:
 
 - [AVA](lib/config/ava.js): Use this for projects that use the

__tests__/index.js

@@ -101,51 +101,15 @@ test("should load the `ava` plugin config in `eslint` to validate all rule synta
   t.is(report.warningCount, 0, "eslint report without warnings");
 });
 
-test("should load the `core` plugin config in `eslint` to validate all rule syntax is correct", t => {
-  const config = Object.assign({}, configs.core);
-  const hasUnicornPlugin = config.plugins.indexOf("unicorn") !== -1;
-  const hasImportPlugin = config.plugins.indexOf("import") !== -1;
-
-  t.true(hasUnicornPlugin, "there is unicorn plugin");
-  t.true(hasImportPlugin, "there is import plugin");
-
-  const cli = new eslint.CLIEngine({
-    baseConfig: config,
-    useEslintrc: false
-  });
-
-  const report = cli.executeOnText(
-    '(function() {\n    "use strict";\n\n    (123).toString();\n})();\n',
-    "test.js"
-  );
-
-  t.is(report.results.length, 1, "eslint report with one results");
-  t.is(report.errorCount, 0, "eslint report without errors");
-  t.is(report.warningCount, 0, "eslint report without warnings");
-});
-
-test("should load the `es5` plugin config in eslint to validate all rule syntax is correct", t => {
-  const config = Object.assign({}, configs.es5);
-  const cli = new eslint.CLIEngine({
-    baseConfig: config,
-    useEslintrc: false
-  });
-
-  const report = cli.executeOnText(
-    '(function() {\n    "use strict";\n\n    (123).toString();\n})();\n',
-    "test.js"
-  );
-
-  t.is(report.results.length, 1, "eslint report with one results");
-  t.is(report.errorCount, 0, "eslint report without errors");
-  t.is(report.warningCount, 0, "eslint report without warnings");
-});
-
 test("should load the `esnext` plugin config in `eslint` to validate all rule syntax is correct", t => {
   const config = Object.assign({}, configs.esnext);
+  const hasUnicornPlugin = config.plugins.indexOf("unicorn") !== -1;
   const hasPromisePlugin = config.plugins.indexOf("promise") !== -1;
+  const hasImportPlugin = config.plugins.indexOf("import") !== -1;
 
+  t.true(hasUnicornPlugin, "there is unicorn plugin");
   t.true(hasPromisePlugin, "there is promise plugin");
+  t.true(hasImportPlugin, "there is import plugin");
 
   config.extends = [];
 
@@ -155,7 +119,7 @@ test("should load the `esnext` plugin config in `eslint` to validate all rule sy
   });
 
   const report = cli.executeOnText(
-    "let foo = 0;\n\n    foo += 1;\n",
+    "/* global func */\nlet foo = 0;\n\n    foo += 1;\n\nfunc(foo);",
     "test.js"
   );
 
@@ -220,7 +184,7 @@ test("should load the `react` plugin config in `eslint` to validate all rule syn
 
   const report = cli.executeOnText(
     `
-import React from "react";
+const React = require("react");
 
 class Clock extends React.Component {
   render() {
@@ -233,7 +197,7 @@ class Clock extends React.Component {
   }
 }
 
-export default Clock;
+module.exports = Clock;
 
   `,
     "test.jsx"

index.js

@@ -2,8 +2,6 @@
 
 const all = require("./lib/config/all");
 const ava = require("./lib/config/ava");
-const core = require("./lib/config/core");
-const es5 = require("./lib/config/es5");
 const esnext = require("./lib/config/esnext");
 const html = require("./lib/config/html");
 const jest = require("./lib/config/jest");
@@ -16,8 +14,6 @@ const utils = require("./lib/utils");
 const configs = {
   all,
   ava,
-  core,
-  es5,
   esnext,
   html,
   jest,
@@ -27,7 +23,4 @@ const configs = {
   react
 };
 
-module.exports = {
-  configs,
-  utils
-};
+module.exports = { configs, utils };

lib/config/ava.js

@@ -3,9 +3,8 @@
 const avaRules = require("./rules/ava");
 
 module.exports = {
-  env: {
-    es6: true
-  },
+  // `AVA` use own `babel` preset what support es6 syntax with `import` but we disable this because
+  // you can configure `babel` for `es3`, `es5`, `es6` and other `es` editions.
   plugins: ["ava"],
   rules: Object.assign({}, avaRules)
 };

lib/config/esnext.js

@@ -1,19 +1,55 @@
 "use strict";
 
-const path = require("path");
+const possibleErrorsRules = require("./rules/possible-errors");
+const bestPracticesRules = require("./rules/best-practices");
+const strictModeRules = require("./rules/strict-mode");
+const variablesRules = require("./rules/variables");
+const stylisticIssuesRules = require("./rules/stylistic-issues");
+const deprecatedRules = require("./rules/deprecated");
 const ecmascript6Rules = require("./rules/ecmascript-6");
 const promiseRules = require("./rules/promise");
+const unicornRules = require("./rules/unicorn");
+const importRules = require("./rules/import");
 
 module.exports = {
   env: {
     es6: true
   },
+  parser: "babel-eslint",
   parserOptions: {
     ecmaVersion: 2019,
     sourceType: "module",
     allowImportExportEverywhere: true
   },
-  plugins: ["promise"],
-  extends: [path.resolve(__dirname, "./core.js")],
-  rules: Object.assign({}, ecmascript6Rules, promiseRules)
+  settings: {
+    "import/resolver": {
+      node: {
+        extensions: [
+          ".mjs",
+          ".js",
+          ".jsx",
+          ".json",
+          ".web.js",
+          ".ios.js",
+          ".android.js"
+        ]
+      }
+    },
+    "import/ignore": ["\\.(coffee|scss|css|less|hbs|svg|json)$"],
+    "import/extensions": [".mjs", ".js", ".jsx"]
+  },
+  plugins: ["unicorn", "promise", "import"],
+  rules: Object.assign(
+    {},
+    possibleErrorsRules,
+    bestPracticesRules,
+    strictModeRules,
+    variablesRules,
+    stylisticIssuesRules,
+    deprecatedRules,
+    ecmascript6Rules,
+    unicornRules,
+    promiseRules,
+    importRules
+  )
 };

lib/config/html.js

@@ -1,8 +1,5 @@
 "use strict";
 
 module.exports = {
-  env: {
-    browser: true
-  },
   plugins: ["html"]
 };

lib/config/jest.js

@@ -3,7 +3,7 @@
 const jestRules = require("./rules/jest");
 
 module.exports = {
-  env: { es6: true },
+  env: { "jest/globals": true },
   plugins: ["jest"],
   rules: Object.assign({}, jestRules)
 };

lib/config/react.js

@@ -9,17 +9,11 @@ module.exports = {
   },
   parserOptions: {
     ecmaVersion: 2019,
-    sourceType: "module",
     ecmaFeatures: {
       jsx: true
     },
     allowImportExportEverywhere: true
   },
-  globals: {
-    fetch: true,
-    ReactElement: true,
-    ReactClass: true
-  },
   settings: {
     react: {
       pragma: "React",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-itgalaxy",
-  "version": "93.0.0",
+  "version": "94.0.0",
   "description": "Itgalaxy org's ESLint rules and configs.",
   "keywords": [
     "eslint",