Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Serving models - updates #215

Closed
wants to merge 3 commits into from
Closed

Conversation

omesser
Copy link
Contributor

@omesser omesser commented Nov 6, 2022

  • update mlem serve command - my bad, was using older mlem
  • add curl CLI example
  • and update verbiage a bit

@omesser omesser requested a review from aguschin November 6, 2022 18:37
@aguschin
Copy link
Contributor

aguschin commented Nov 7, 2022

@omesser, please note that PR from forks doesn't allow to deploy this to preview envs #211 (comment)

Next time please just create a branch with changes in this exact repo :)

@aguschin
Copy link
Contributor

aguschin commented Nov 7, 2022

Errr, http://example-mlem-get-started-app.herokuapp.com doesn't loads for me. I see some recent requests to it though. Looks like heroku can't handle the load? 🤔

@omesser omesser requested a review from aguschin November 7, 2022 10:33
@omesser omesser changed the title Serving models - Update broken/obsolete command Serving models - updates Nov 7, 2022
@omesser omesser mentioned this pull request Nov 7, 2022
@shcheklein shcheklein temporarily deployed to mlem-ai-serving-fixes-ntzooow4 November 7, 2022 13:12 Inactive
@omesser
Copy link
Contributor Author

omesser commented Nov 7, 2022

@omesser, please note that PR from forks doesn't allow to deploy this to preview envs #211 (comment)

Next time please just create a branch with changes in this exact repo :)

continuing here #217 - from a branch pushed to this fork (upstream).
But this repo is a public repo - it should work with contributions (=prs from forks) - fully 😄 I hope we can fix this soon

@omesser omesser closed this Nov 7, 2022
@jorgeorpinel
Copy link
Contributor

this repo is a public repo - it should work with contributions (=prs from forks) - fully

This is a discussion for @iterative/websites I think, but some of the features (example Restyled) specifically cannot be trusted to work on forked PRs due to security concerns. Probably the same with review apps: this would give any random user the ability to deploy things to our test infrastructure.

@jorgeorpinel jorgeorpinel added the A: docs Area: user documentation (gatsby-theme-iterative) label Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: docs Area: user documentation (gatsby-theme-iterative)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants