Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ultralytics models (take two) #613

Merged
merged 13 commits into from
Nov 22, 2024
Merged

Update ultralytics models (take two) #613

merged 13 commits into from
Nov 22, 2024

Conversation

dreadatour
Copy link
Contributor

@dreadatour dreadatour commented Nov 21, 2024

Update Ultralytics YOLO models to be used in SaaS.

This adds:

  • Segment model and common YoloBBox, YoloBBoxes, YoloPose, YoloPoses, YoloSegment and YoloSegments models to be used to parse ultralytics results
  • Ultralytics models usage examples
  • Move models from datachain.lib.models to datachain.model (I suppose to move datachain.lib.data_model to datachain.model in future to slowly get rid of lib package)

@dreadatour dreadatour requested a review from a team November 21, 2024 18:46
@dreadatour dreadatour self-assigned this Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 64 lines in your changes missing coverage. Please review.

Project coverage is 87.64%. Comparing base (894c13d) to head (c80c920).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/model/ultralytics/bbox.py 51.61% 30 Missing ⚠️
src/datachain/model/ultralytics/pose.py 69.64% 17 Missing ⚠️
src/datachain/model/ultralytics/segment.py 55.26% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
- Coverage   88.04%   87.64%   -0.40%     
==========================================
  Files         102      106       +4     
  Lines       10086    10280     +194     
  Branches     1373     1385      +12     
==========================================
+ Hits         8880     9010     +130     
- Misses        865      929      +64     
  Partials      341      341              
Flag Coverage Δ
datachain 87.58% <73.33%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@0x2b3bfa0
Copy link
Member

/vlad lint 🙏

src/datachain/model/bbox.py Outdated Show resolved Hide resolved
src/datachain/model/ultralytics/bbox.py Outdated Show resolved Hide resolved
Copy link

cloudflare-workers-and-pages bot commented Nov 22, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: c80c920
Status: ✅  Deploy successful!
Preview URL: https://c61b1e19.datachain-documentation.pages.dev
Branch Preview URL: https://models-ultralytics.datachain-documentation.pages.dev

View logs

@dreadatour
Copy link
Contributor Author

Attention: Patch coverage is 73.33333% with 64 lines in your changes missing coverage. Please review.

src/datachain/model/ultralytics/bbox.py 51.61% 30 Missing ⚠️
src/datachain/model/ultralytics/pose.py 69.64% 17 Missing ⚠️
src/datachain/model/ultralytics/segment.py 55.26% 17 Missing ⚠️

These methods are tested in examples (1, 2, 3). Adding tests for them requires installing ultralytics dependency and downloading models, which will increase tests run time. Still not sure if this is a good idea. Also we can do it in follow-up PRs.

@dreadatour dreadatour merged commit 224f8a6 into main Nov 22, 2024
37 of 38 checks passed
@dreadatour dreadatour deleted the models-ultralytics branch November 22, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants