Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README #26

wants to merge 1 commit into from

Conversation

sidwarkd
Copy link

@sidwarkd sidwarkd commented Dec 2, 2016

Fix some typos and grammatical errors

Fix some typos and grammatical errors
@s-celles
Copy link

s-celles commented May 5, 2018

I really wonder why such a PR is not merged!

@s-celles
Copy link

s-celles commented Sep 1, 2018

Pinging @shennongmin @zhangabc @hxming123456 @huangxianming
Any idea why this PR is not merged?

@s-celles
Copy link

s-celles commented May 2, 2020

@ekhiw do you know what is locking for merge?

@ekhiw
Copy link

ekhiw commented May 2, 2020

@scls19fr it also makes me wonder, all PR is correct and has no conflict.

@s-celles
Copy link

s-celles commented May 3, 2020

@ekhiw someone grant you as "reviewer"... maybe you can also merge.
If not maybe you can tell us who grant you as reviewer.

@ekhiw
Copy link

ekhiw commented May 3, 2020

@scls19fr no, just review some file and approve, then you become a reviewer. nobody grant me as reviewer

@s-celles
Copy link

s-celles commented May 3, 2020

Oh yes @ekhiw you are right I'm "reviewer" also. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants