Migrate from Python2 to Python 3 #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogasp
changed the title
jacogasp
commented
Oct 8, 2024
| output = mysql_proc.stdout.read() | ||
| msg = f"Error dropping MySQL database {options.dbname}: {output}" | ||
| error_and_exit(msg) | ||
| print("Done.") | ||
|
|
||
|
|
||
| def grant_rw_access(options): |
There was a problem hiding this comment.
I don't know why git is not highlighting this line. In the main branch, the options argument is not defined and thus I cannot understand how this could work
I added the argument because how I guess that function was supposed to be used.
|
Can I contribute a pre-commit hook to run flake8 / black on the scripts ? Can we add an action to validate the python3? |
|
Superseded by PR #78 |
|
Hi @brucellino! Thank you for reaching us, your contribution is very welcome! We can discuss the development in this issue #77. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft, even though "complete", since it hasn't been tested due to the lack of documentation about its usage.