#988 Add color to Calculator #997
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielVajnagi
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## calculators-constructor #997 +/- ##
===========================================================
+ Coverage 86.74% 86.75% +0.01%
===========================================================
Files 68 68
Lines 1056 1057 +1
===========================================================
+ Hits 916 917 +1
Misses 140 140 ☔ View full report in Codecov by Sentry. |
SleekMutt
approved these changes
Dec 2, 2024
loqimean
requested changes
Dec 3, 2024
| <%= f.input :color, as: :color, label: 'Choose a Color for Calculator Page:', | ||
| input_html: { | ||
| class: 'form-control form-control-color p-2', | ||
| style: 'width: 7rem; height: 3.5rem;' |
| @@ -35,6 +36,7 @@ class Calculator < ApplicationRecord | |||
| validates :en_name, :uk_name, presence: true | |||
| validates :en_name, :uk_name, length: { minimum: 3, maximum: 50 } | |||
| validates :slug, presence: true, uniqueness: true | |||
| validates :color, format: { with: /\A#[0-9a-fA-F]{6}\z/ } | |||
loqimean
requested changes
Dec 4, 2024
Comment on lines
+43
to
+44
| width: 7rem; | ||
| height: 3.5rem; |
There was a problem hiding this comment.
Suggested change
| width: 7rem; | |
| height: 3.5rem; | |
| @apply w-28 h-14; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code reviewers
Second Level Review
Summary of issue
Add color picker to calculator
Summary of change
Added color field in model, created partial for picking color
CHECK LIST