Increase coverage of project #934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #934 +/- ##
===========================================
+ Coverage 91.16% 94.01% +2.85%
===========================================
Files 70 68 -2
Lines 973 969 -4
===========================================
+ Hits 887 911 +24
+ Misses 86 58 -28 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…ial-projects/ZeroWaste into 930-increase-coverage-of-project
render
bot
temporarily deployed
to
930-increase-coverage-of-project - zero-waste-staging PR #934
…ial-projects/ZeroWaste into 930-increase-coverage-of-project
6 tasks
loqimean
requested changes
Dec 1, 2024
| @@ -0,0 +1,7 @@ | |||
| FactoryBot.define do | |||
| factory :authorization do | |||
| uid { "unique_uid" } | |||
Comment on lines
+144
to
+148
| product.attributes = { | ||
| prices_attributes: [ | ||
| { sum: 100 } | ||
| ] | ||
| } |
There was a problem hiding this comment.
NEVER use local vars in specs
Comment on lines
+156
to
+158
| before do | ||
| sign_in user | ||
| end |
There was a problem hiding this comment.
use shared context, it's already present
| @@ -22,6 +22,14 @@ | |||
| end | |||
| end | |||
|
|
|||
| context "redirect to root_url" do | |||
| it "is successful" do | |||
| get "/" | |||
| describe "#perform!" do | ||
| context "when preferable is set to 1" do | ||
| it "updates other calculators to have preferable set to false" do | ||
| service = Calculators::PreferableService.new(preferable: 1, slug: calculator1.slug) |
loqimean
force-pushed
the
develop
branch
4 times, most recently
from
03a3caf
to
7d2dc81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev #930
Code reviewers
Summary of issue
Increase coverage of project
Summary of change
Testing approach
Run coverage localy
CHECK LIST