Update Ruby on Rails to 7.2.0 #929

KseniaGovorun · 2024-10-30T13:33:14Z

dev

Project ticket #891

Code reviewers

@loqimean

Summary of issue

Update Ruby on Rails to latest

Summary of change

Updated Ruby on Rails to 7.2.0

CHECK LIST

СI passed
Сode coverage >=95%
PR is reviewed manually again (to make sure you have 100% ready code)
All reviewers agreed to merge the PR
PR meets all conventions

codecov · 2024-10-30T13:47:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.73%. Comparing base (4cf826e) to head (3f4f0ea).
Report is 5 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #929      +/-   ##
===========================================
+ Coverage    91.82%   96.73%   +4.91%     
===========================================
  Files           74       73       -1     
  Lines         1052     1012      -40     
===========================================
+ Hits           966      979      +13     
+ Misses          86       33      -53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

loqimean

зкооперуйся з Іванною Амброзяк, разом гляньте до цього ПРа, до її, аби все гарно зробити

loqimean · 2024-11-05T07:30:58Z

config/environments/development.rb

-  config.action_mailer.delivery_method    = :letter_opener
-  config.action_mailer.perform_deliveries = true


а чому цей конфіг видалений?

loqimean · 2024-11-05T07:31:55Z

config/environments/production.rb

-  config.action_mailer.delivery_method       = :smtp
-  config.action_mailer.raise_delivery_errors = true
-  config.action_mailer.perform_deliveries    = true
-  config.action_mailer.default_url_options   = {
-    host: "zero-waste-project.herokuapp.com",
-    protocol: "https"
-  }
-  config.action_mailer.smtp_settings = {
-    address: "smtp.sendgrid.net",
-    port: 587,
-    domain: "zero-waste-project.herokuapp.com",
-    user_name: ENV.fetch("SENDGRID_USERNAME", nil),
-    password: ENV.fetch("SENDGRID_API_KEY", nil),
-    authentication: "plain",
-    enable_starttls_auto: true
-  }


чому цей конфіг видалений?

loqimean · 2024-11-05T07:32:18Z

config/environments/production.rb

+  # config.assume_ssl = true
+
+  # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
+  config.force_ssl = true


а чому це додала?

loqimean · 2024-11-05T07:33:01Z

config/initializers/new_framework_defaults_7_2.rb

тут же пише, що цей файл має бути видалений. Також я хотів би, аби максимальний розмір лог файла, з цього файла, був винесений в конфігурацію

loqimean · 2024-11-05T07:33:27Z

public/icon.png

нам цього не потрібно

loqimean · 2024-11-05T07:35:14Z

db/migrate/20241030095709_remove_not_null_on_active_storage_blobs_checksum.active_storage.rb

а нам ця міграція потрібна?

loqimean · 2024-11-05T07:35:26Z

db/migrate/20241030095707_add_service_name_to_active_storage_blobs.active_storage.rb

також всі ці інші міграції?

loqimean · 2024-11-09T09:49:11Z

spec/lib/users_csv_generator_spec.rb

@@ -3,7 +3,7 @@
 require "rails_helper"

 RSpec.describe UsersCsvGenerator do
-  let(:time_login) { Time.new(2020, 0o1, 0o1).in_time_zone("Kyiv") }
+  let(:time_login) { Time.new(2020, 0o1, 0o1).in_time_zone("Europe/Kyiv") }


Suggested change

let(:time_login) { Time.new(2020, 0o1, 0o1).in_time_zone("Europe/Kyiv") }

let(:time_login) { Time.new(2020, 0o1, 0o1) }

Rubocop не дозволяє

loqimean · 2024-11-09T09:49:29Z

config/application.rb

    # Configuration for the application, engines, and railties goes here.
    #
    # These settings can be overridden in specific environments using the files
    # in config/environments, which are processed later.
    #
-    config.time_zone = "Kyiv"
+    # config.time_zone = "Central Time (US & Canada)"


де таймзона?)))

loqimean · 2024-11-09T09:49:43Z

config/application.rb

-    config.i18n.available_locales   = [:en, :uk]
-    config.i18n.default_locale      = :en
-
-    config.i18n.load_path += Dir[Rails.root.join("config", "locales", "**", "*.{rb,yml}")]


а це чому видалила?

config/environments/production.rb

loqimean · 2024-11-09T09:51:36Z

config/environments/production.rb

  # config.action_mailer.raise_delivery_errors = false

  # Enable locale fallbacks for I18n (makes lookups for any locale fall back to
  # the I18n.default_locale when a translation cannot be found).
  config.i18n.fallbacks = true

-  # Send deprecation notices to registered listeners.
-  config.active_support.deprecation = :notify


повертай

config/environments/test.rb

config/initializers/assets.rb

config/puma.rb

loqimean · 2024-11-26T10:14:46Z

config/environments/production.rb

+  config.logger = ActiveSupport::Logger.new($stdout)
+                                       .tap  { |logger| logger.formatter = ::Logger::Formatter.new }
+                                       .then { |logger| ActiveSupport::TaggedLogging.new(logger) }


це не гуд взагалі, глянь, як було, раніше була умова на цей конфіг

loqimean · 2024-12-01T12:48:31Z

Gemfile

+  gem "rubocop-factory_bot"
+  gem "rubocop-capybara"


require false

loqimean · 2024-12-01T12:49:11Z

config/environments/test.rb


  # Show full error reports and disable caching.
  config.consider_all_requests_local = true
  config.action_controller.perform_caching = false
  config.cache_store = :null_store

-  # Raise exceptions instead of rendering exception templates.
+  # Render exception templates for rescuable exceptions and raise for other exceptions.
  config.action_dispatch.show_exceptions = :none


через цю штуку тести падають

KseniaGovorun added 9 commits October 30, 2024 12:08

Update rails to 7.2

9955a6d

Fixed rubocop

af639ee

Fixed tailwindcss

c1986ca

Fixed rspec

74a91b5

Fixed rubocop

a99f051

Changed LintEnv instead Lint::Env

a3a172b

Fixed rubocop

2b6d482

Fixed rubocop

5f67f9f

Renamed the folder rubo_cop

2f6f4f7

KseniaGovorun requested a review from loqimean October 30, 2024 13:33

render bot had a problem deploying to 891-dev-update-rails-7.2 - zero-waste-staging PR #929 October 30, 2024 13:33 Failure

Fixed rubocop

9a8c8ce

render bot had a problem deploying to 891-dev-update-rails-7.2 - zero-waste-staging PR #929 October 30, 2024 13:45 Failure

Added ruby-vips

6b74e34

render bot had a problem deploying to 891-dev-update-rails-7.2 - zero-waste-staging PR #929 October 30, 2024 19:05 Failure

Changed ci.yml

cf1ad85

render bot had a problem deploying to 891-dev-update-rails-7.2 - zero-waste-staging PR #929 October 30, 2024 19:15 Failure

Fixed timezone

9fde219

render bot had a problem deploying to 891-dev-update-rails-7.2 - zero-waste-staging PR #929 October 30, 2024 19:57 Failure

Fixed inflections.rb and time_login

5c682c4

render bot had a problem deploying to 891-dev-update-rails-7.2 - zero-waste-staging PR #929 October 30, 2024 20:28 Failure

KseniaGovorun requested review from ktpe and olexandervanzuriak and removed request for ktpe October 30, 2024 20:38

loqimean requested changes Nov 5, 2024

View reviewed changes

loqimean mentioned this pull request Nov 5, 2024

Update Ruby on Rails to latest #891

Open

Fixed after review

5c96623

render bot had a problem deploying to 891-dev-update-rails-7.2 - zero-waste-staging PR #929 November 6, 2024 15:02 Failure

loqimean requested changes Nov 9, 2024

View reviewed changes

loqimean linked an issue Nov 9, 2024 that may be closed by this pull request

Update Ruby on Rails to latest #891

Open

KseniaGovorun self-assigned this Nov 11, 2024

Added configs

a97ca15

render bot had a problem deploying to 891-dev-update-rails-7.2 - zero-waste-staging PR #929 November 18, 2024 19:23 Failure

Deleted Europe in timezone

3e47a49

render bot had a problem deploying to 891-dev-update-rails-7.2 - zero-waste-staging PR #929 November 18, 2024 19:32 Failure

loqimean requested changes Nov 26, 2024

View reviewed changes

Deleted logger by default

9ce562f

loqimean approved these changes Nov 26, 2024

View reviewed changes

olexandervanzuriak approved these changes Nov 26, 2024

View reviewed changes

KseniaGovorun force-pushed the 891-dev-update-rails-7.2 branch from 06ed92a to 9ce562f Compare November 30, 2024 19:28

KseniaGovorun added 5 commits November 30, 2024 21:58

Merge branch 'develop' into 891-dev-update-rails-7.2

d574847

Updated gemfile

776cf2e

Fixed rspec mhc_calculator

c00152f

Changed schema

31c5f50

Changed config

d6efd56

loqimean requested changes Dec 1, 2024

View reviewed changes

KseniaGovorun added 3 commits December 1, 2024 14:53

Resolved comments

44f9e21

Deleted require:false

793e8c8

Deleted lint_env

3f4f0ea

loqimean force-pushed the develop branch 4 times, most recently from 03a3caf to 7d2dc81 Compare December 2, 2024 12:04

loqimean approved these changes Dec 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Ruby on Rails to 7.2.0 #929

Update Ruby on Rails to 7.2.0 #929

KseniaGovorun commented Oct 30, 2024 •

edited

Loading

codecov bot commented Oct 30, 2024 •

edited

Loading

loqimean left a comment

loqimean Nov 5, 2024

loqimean Nov 5, 2024

loqimean Nov 5, 2024

loqimean Nov 5, 2024

loqimean Nov 5, 2024

loqimean Nov 5, 2024

loqimean Nov 5, 2024

loqimean Nov 9, 2024

KseniaGovorun Nov 18, 2024

loqimean Nov 9, 2024

loqimean Nov 9, 2024

loqimean Nov 9, 2024

loqimean Nov 26, 2024

loqimean Dec 1, 2024

loqimean Dec 1, 2024

		config.action_mailer.delivery_method = :letter_opener
		config.action_mailer.perform_deliveries = true

	let(:time_login) { Time.new(2020, 0o1, 0o1).in_time_zone("Europe/Kyiv") }
	let(:time_login) { Time.new(2020, 0o1, 0o1) }

Update Ruby on Rails to 7.2.0 #929

Are you sure you want to change the base?

Update Ruby on Rails to 7.2.0 #929

Conversation

KseniaGovorun commented Oct 30, 2024 • edited Loading

Code reviewers

Summary of issue

Summary of change

CHECK LIST

codecov bot commented Oct 30, 2024 • edited Loading

Codecov Report

loqimean left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KseniaGovorun commented Oct 30, 2024 •

edited

Loading

codecov bot commented Oct 30, 2024 •

edited

Loading