Feature/creating calculators constructor #534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://zero-waste-staging-pr-534.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cj3ut3dgkuvmu7li1crg. |
14 tasks
loqimean
reviewed
Aug 2, 2023
| @@ -1,15 +1,20 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class Account::CalculatorsController < Account::BaseController | |||
| before_action :calculator, only: [:edit, :update, :destroy] | |||
| before_action :calculator, only: [:show, :edit, :update, :destroy] | |||
| end | ||
| end | ||
|
|
||
| def products_collection | ||
| Product.all |
| end | ||
|
|
||
| def product_resource | ||
| Product.find(@calculator.product_id) |
| @@ -0,0 +1,5 @@ | |||
| class AddProductIdToCalculators < ActiveRecord::Migration[6.1] | |||
| def change | |||
| add_column :calculators, :product_id, :integer | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #534 +/- ##
===========================================
- Coverage 91.16% 90.90% -0.27%
===========================================
Files 70 73 +3
Lines 973 1011 +38
===========================================
+ Hits 887 919 +32
- Misses 86 92 +6 ☔ View full report in Codecov by Sentry. |
loqimean
force-pushed
the
develop
branch
7 times, most recently
from
9fa42f9
to
3bff2f0
Compare
Comment on lines
14
to
26
| <%= form.input_field :period, | ||
| collection: use_period, | ||
| prompt: '__', | ||
| class: 'form_fild price_select rounded w-100', | ||
| data: { calculate_target: 'period' } %> | ||
|
|
||
| <%= t("calculators.form.price") %> | ||
| <%= form.input_field :product_category, | ||
| collection: product_prices(@calculator), | ||
| prompt: '__', | ||
| label: t('.form_price'), | ||
| class: 'form_fild price_select rounded w-100', | ||
| data: { calculate_target: 'priceCategory' } %> |
There was a problem hiding this comment.
а чому не просто form.input?
loqimean
force-pushed
the
develop
branch
4 times, most recently
from
03a3caf
to
7d2dc81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code reviewers
Summary of issue
Create calculator's constructor
Summary of change
_.ZeroWaste.webm
CHECK LIST