Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/event card style #2635

Merged
merged 22 commits into from
Sep 3, 2023
Merged

Feature/event card style #2635

merged 22 commits into from
Sep 3, 2023

Conversation

mdashko
Copy link
Contributor

@mdashko mdashko commented Aug 16, 2023

No description provided.

@mdashko mdashko self-assigned this Aug 16, 2023
@@ -59,6 +59,10 @@ export class EventsService implements OnDestroy {
);
}

public getUserFavoriteEvents(): Observable<EventResponseDto> {
return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the point of this method?) remove it

this.eventType = '';
}

this.initGetUserEvents(this.eventType);
}

public escapeFromFavorites(): void {
this.isFavoriteBtnClicked = !this.isFavoriteBtnClicked;
console.log('go out');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.log


public goToFavorites(): void {
this.isFavoriteBtnClicked = true;
console.log('here');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

});
}

getUserFavouriteEvents(eventType?: string): void {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this method

@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.4% 90.4% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@hnativlyubomyr hnativlyubomyr merged commit eb309df into dev Sep 3, 2023
2 checks passed
@hnativlyubomyr hnativlyubomyr deleted the Feature/event_card_style branch September 3, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants