-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/event card style #2635
Feature/event card style #2635
Conversation
@@ -59,6 +59,10 @@ export class EventsService implements OnDestroy { | |||
); | |||
} | |||
|
|||
public getUserFavoriteEvents(): Observable<EventResponseDto> { | |||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the point of this method?) remove it
this.eventType = ''; | ||
} | ||
|
||
this.initGetUserEvents(this.eventType); | ||
} | ||
|
||
public escapeFromFavorites(): void { | ||
this.isFavoriteBtnClicked = !this.isFavoriteBtnClicked; | ||
console.log('go out'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove console.log
|
||
public goToFavorites(): void { | ||
this.isFavoriteBtnClicked = true; | ||
console.log('here'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same
}); | ||
} | ||
|
||
getUserFavouriteEvents(eventType?: string): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this method
Kudos, SonarCloud Quality Gate passed! 0 Bugs 90.4% Coverage The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
No description provided.