Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/#5700 Events. join button is visible for close event (only organizer's friends can join) #2627

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Bugfix/#5700 Events. join button is visible for close event (only organizer's friends can join) #2627

merged 4 commits into from
Aug 18, 2023

Conversation

OksanaFilipchuk
Copy link
Contributor

Bugfix/#5700 Events. join button is visible for a close event (only organizer's friends can join)

Summary Of Changes 🔥

Added list of user's friends to check if the organizer is a friend

Issue Link 📋

Bug 5700

Added

  • method getAllFriendsByUserId in UserFriendService
  • method which checks can user join a close event
  • join button is hidden if an event is close and the user and organizer aren't friends

PR Checklist Forms

(to be filled out by PR submitter)

  • Code is up-to-date with the dev branch.
  • You've successfully built and run the tests locally.
  • There are new or updated unit tests validating the change.
  • JIRA/ Github Issue number & title in PR title (ISSUE-XXXX: Ticket title)
  • This template filled (above this section).
  • Sonar's report does not contain bugs, vulnerabilities, security issues, code smells ar duplication
  • NEED_REVIEW and READY_FOR_REVIEW labels are added.
  • All files reviewed before sending to reviewers

@OksanaFilipchuk OksanaFilipchuk changed the title Bugfix/#5700 Events. join button is visible for close event (only orginizer's friends can join) Bugfix/#5700 Events. join button is visible for close event (only organizer's friends can join) Aug 10, 2023
@OksanaFilipchuk OksanaFilipchuk self-assigned this Aug 11, 2023
@OksanaFilipchuk OksanaFilipchuk force-pushed the bugfix/#5700join-button-visible-for-close-event branch 3 times, most recently from f5bd9d4 to 629322d Compare August 17, 2023 15:17
@OksanaFilipchuk OksanaFilipchuk force-pushed the bugfix/#5700join-button-visible-for-close-event branch from 629322d to 037bd96 Compare August 18, 2023 11:40
@OksanaFilipchuk OksanaFilipchuk force-pushed the bugfix/#5700join-button-visible-for-close-event branch from 037bd96 to d47204c Compare August 18, 2023 11:44
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.9% 90.9% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@hnativlyubomyr hnativlyubomyr merged commit 14a2a1c into dev Aug 18, 2023
2 checks passed
@hnativlyubomyr hnativlyubomyr deleted the bugfix/#5700join-button-visible-for-close-event branch August 18, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tadei-Mykola Tadei-Mykola Tadei-Mykola approved these changes

@sobkiv sobkiv sobkiv approved these changes

@mdashko mdashko mdashko approved these changes

@katia9261 katia9261 katia9261 approved these changes

@hnativlyubomyr hnativlyubomyr hnativlyubomyr approved these changes

Assignees

@OksanaFilipchuk OksanaFilipchuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@OksanaFilipchuk @hnativlyubomyr @katia9261 @mdashko @sobkiv @Tadei-Mykola