Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed group chat room management methods. ChatRoomService refactoring. #103

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

Maryna-511750
Copy link
Collaborator

@Maryna-511750 Maryna-511750 commented Aug 10, 2024

GreenCityChat PR

Summary Of Changes 🔥

  1. Fixed group chat room management methods:
  • Added validation check in methods of updating chat room (updateChatRoom) and deleting users from chat room (deleteParticipantsFromChatRoom).
  1. ChatRoomService refactoring:
  • The code that is not used anywhere has been removed.
  • Removed code duplication.
  • Fixed some method names to better understand their functionality.
  • Fixed logic in methods of ChatRoomServiceImpl file: findSystemChatByParticipantsForSockets, getTariffIdByLocationId, deleteMessagesFromChatRoom.
  1. Showing number of unread messages for every user chat:
  • Added display of number of unread messages to chat rooms in all methods returning ChatRoomDto or List.

PR Checklist Forms

(to be filled out by PR submitter)

  • Code is up-to-date with the dev branch.
  • You've successfully built and run the tests locally.
  • There are new or updated unit tests validating the change.
  • JIRA/ Github Issue number & title in PR title (ISSUE-XXXX: Ticket title)
  • This template filled (above this section).
  • Sonar's report does not contain bugs, vulnerabilities, security issues, code smells or duplication
  • NEED_REVIEW and READY_FOR_REVIEW labels are added.
  • All files reviewed before sending to reviewers

Copy link

sonarcloud bot commented Aug 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants