-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for issue #182 #190
base: dev
Are you sure you want to change the base?
Conversation
… 2.Shared cookies middleware to share cookies between crawl nodes
if 'cookie' in item and item['cookie'] is not None: | ||
if isinstance(item['cookie'], dict): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code was not getting executed because kafka scraper_schema.json is only forcing it to be string. So I added attribute cookies
to scraper_schema. Not sure if it make sense.
Custom feed will look like this python kafka_monitor.py feed { |
Due to shared cookie middle ware the coverage has decreased by 0.4%. @madisonb do you think this can be managed? I improved few percentage in distributed_scheduler. |
Adding support for
1.Custom Headers and Cookies with Initial request
2.Shared cookies middleware to share cookies between crawl nodes
Linked Issue #182