Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 3 additions & 22 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,31 +116,12 @@ The branch PR can then be merged into master.
Once the branch PR is merged into master, run [the publish action](https://github.com/isovalent/olm-for-cilium/actions/workflows/publish.yaml) on the
master branch, defining the version to be published ("1.14.3" for example).

Once the action has completed successfully, you can now submit the image conformance tests to Redhat.
For this you will need to access [RedHat Partner Connect][] registry and obtain credentials for logging
into the regsitry and setting the preflight API key.
Once the action has completed successfully, the image will now be certified by RedHat registry.

Export the following environment variables using the credentials from RedHat Partner Connect:

- `export RHPC_PASSWORD_FOR_OLM_OPERATOR_IMAGE="_____"`
- `export RHCP_PREFLIGHT_API_KEY="_____"`

Next, login to the registry:

```sh
podman login -u unused scan.connect.redhat.com -p $RHPC_PASSWORD_FOR_OLM_OPERATOR_IMAGE
```

Next, run the preflight checks on the image:

```sh
PFLT_DOCKERCONFIG=~/.docker/config.json preflight check container --pyxis-api-token=$RHCP_PREFLIGHT_API_KEY --submit --certification-project-id=ospid-104ec1da-384c-4d7c-bd27-9dbfd8377f5b scan.connect.redhat.com/ospid-104ec1da-384c-4d7c-bd27-9dbfd8377f5b/cilium-olm:v1.10.0
```

Next, login to [Redhat Parnter Connect][] and click "Publish" on the image (once the vulnerability scanning is done).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you are relying on

olm-for-cilium/.github/workflows/publish.yaml

Lines 56 to 65 in d08076c

- name: Run Preflight
run: |
ls ~/.docker
cat ~/.docker/config.json
preflight check container \
--pyxis-api-token=${{ secrets.RHCP_PREFLIGHT_API_KEY }} \
-d ~/.docker/config.json \
--submit \
--certification-project-id=5fbe31ec8b7d4976604cbde0 \
quay.io/redhat-isv-containers/5fbe31ec8b7d4976604cbde0:${{ env.OLM_TAG }}
to make the above redundant.

Once the certification finishes, login to [Redhat Parnter Connect][] and click "Publish" on the image (once the vulnerability scanning is done).

Once the image is published open a new PR in the [isovalent/certified-operators-cilium](https://github.com/isovalent/certified-operators-cilium), by adding the
new manifests to the appropriately named new directory under `operators/cilium` (`operators/cilium/v1.14.3`, for example).
new manifests to the appropriately named new directory under `operators/cilium` (`operators/cilium/1.14.3`, for example).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the rational for removing the "v"? It is also present under bundles and manifests.

Before commiting your changes make sure to modify the `image` reference in the `manifests/cilium.clusterserviceversion.yaml` so that
the sha256 tag of the image is used (rather than the semantic tag).

Expand Down