03 27 feat egazette add filtering #399
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/next-gen
release/next-gen
release: next-gen
fix(hero): set max width
release: style fixes
release/next-gen
Release/next-gen
Release: 26 October 2023
release/next-gen
release/next-gen-develop
fix(icons): update asset path
* feat(cards): add css styling for page cards block (#360) * feat(cards): add css styling for page cards block * feat(cards): add support for clickable cards * styles(colors): add more color tokens from design * styles(cards): update based on design feedback * styles(cards): add bottom margin if not last child * fix: prevent staging sites from being indexed by robots (#369) --------- Co-authored-by: Hsu Zhong Jun <[email protected]> Co-authored-by: seaerchin <[email protected]>
release/next-gen
fix: prettify dgs-v2 search term (#373)
chore/retrieve field name before dgs query (#375)
kishore03109
force-pushed
the
03-27-feat_egazette_add_filtering
branch
from
f68f98b to
27fcad5
Compare
kishore03109
requested review from
harishv7,
alexanderleegs and
a team
and removed request for
harishv7 and
alexanderleegs
kishore03109
force-pushed
the
03-27-feat_egazette_add_filtering
branch
from
27fcad5 to
c6a5620
Compare
kishore03109
force-pushed
the
03-27-feat_egazette_add_filtering
branch
from
c6a5620 to
439b1dd
Compare
_layouts/egazette-search.html
Outdated
Comment on lines
52
to
57
| <h5 class="margin--bottom--sm">Select day</h5> | ||
| <div id="refinement-list-day" class="margin--bottom"></div> | ||
|
|
||
| <h5 class="margin--bottom--sm">Select month</h5> | ||
| <div id="refinement-list-month" class="margin--bottom"></div> | ||
|
|
There was a problem hiding this comment.
I think we can remove these now right!
_layouts/egazette-search.html
Outdated
Comment on lines
63
to
64
| <!-- <div id="current-refinements"></div> | ||
| <div id="clear-refinements"></div> --> |
There was a problem hiding this comment.
Is this meant to be commented out?
assets/js/algolia-search.js
Outdated
| @@ -4,7 +4,7 @@ const searchClient = algoliasearch( | |||
| ); | |||
|
|
|||
| const search = instantsearch({ | |||
| indexName: "ogp_egazettes_index", | |||
| indexName: "staging_ogp_egazettes_index", | |||
There was a problem hiding this comment.
Will need to swap this back - prod is using this search currently
kishore03109
force-pushed
the
03-27-feat_egazette_add_filtering
branch
from
481c5c1 to
0efa8f6
Compare
harishv7
reviewed
Apr 9, 2024
| // const algoliaIndexName = isProd | ||
| // ? "ogp_egazettes_index" | ||
| // : "staging_ogp_egazettes_index"; | ||
| const algoliaIndexName = "test_snippet_1"; |
There was a problem hiding this comment.
this should be fixed before merge
if this is a test pr, let's mark it as a draft pr
There was a problem hiding this comment.
ya converting to draft, the main data set is not ready for filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
add filtering functionality to egazette.
Solution
Screen.Recording.2024-03-27.at.6.12.59.PM.mov
still got design bugs:
search filters in the same category look ugly.
rm notification number, looks useless