Feat: remove extra page sidebar icons #274
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderleegs
requested review from
seaerchin,
dcshzj,
kishore03109 and
prestonlimlianjie
|
Haven't reviewed the code yet but should we pick a small pool of users at random to see if this is an issue? I'm actually worried that this might be a case of vocal minority, and most of our users are ambivalent/think it's useful. Wdyt about this? |
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting as draft - we haven't done the user interviews to determine if this is a significant issue and this is relatively low impact
This PR removes the sidebar icons (email, facebook, linkedin) from all pages, as agencies were providing feedback that sharing pages through these means were not useful and providing confusion to users.