Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pr-template): add checkbox for ssm and 1pw for env var #953

Merged
merged 1 commit into from
Oct 5, 2023
Merged

docs(pr-template): add checkbox for ssm and 1pw for env var #953

merged 1 commit into from
Oct 5, 2023
+1 −0

Conversation

seaerchin
Copy link
Contributor

Problem

Env vars are required in quite a few places but we have to remember this manually. This PR updates the PR template so there's a reminder

Solution

Update PR template to have check for env var to add to 1pw + ssm

@seaerchin seaerchin requested a review from a team October 3, 2023 06:20
@seaerchin seaerchin merged commit 12d6123 into develop Oct 5, 2023
14 checks passed
@seaerchin seaerchin deleted the chore/add-template branch October 5, 2023 03:36
@alexanderleegs alexanderleegs mentioned this pull request Oct 5, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harishv7 harishv7 harishv7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @harishv7