IS-621: fix issues for staging deploy node 18 #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishv7
requested review from
seaerchin,
alexanderleegs,
dcshzj and
kishore03109
and removed request for
seaerchin
alexanderleegs
approved these changes
Sep 28, 2023
mergify
bot
deleted the
IS-621-fix-issues-for-staging-deploy-node-18
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
New Node env on AWS has issues with bcrypt as it depends on some C++ libs which probably don't exist.
Closes IS-621
Solution
Swapping to use bcryptjs which does not have such dependencies.
See this
Breaking Changes
Tests
Ensure all unit tests pass
Deploy Notes
Removed dependencies:
bcrypt: has compat issues with new node envNew dependencies:
bcryptjs: alternative for bcryptRemoved dev dependencies:
@types/bcrypt: type defs for bcryptNew dev dependencies:
@types/bcryptjs: type defs for bcryptjs