Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(siteCreate): add redirect rules #1036

Merged
merged 2 commits into from
Nov 16, 2023
Merged

fix(siteCreate): add redirect rules #1036

merged 2 commits into from
Nov 16, 2023

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Nov 15, 2023

Problem

Stg lite never configure properly, the url not correct + the redirect rules were not present + for reasons I do not know why there were blips when some of the sites had their jobs queued + it did not start even after a while. As such am pinging Amplify to release the jobs. Not sure if this completely fixes it, not sure why we have this issue now, so intent here is to add the release job + monitor for tickets.

Tests

running this in server.js


deploymentsService.createAmplifyAppOnAws(
  "kishore-test-dev-gh",
  "kishore-test-again-delete-me",
  false
)

deploymentsService.createAmplifyAppOnAws(
  "kishore-test-dev-gh",
  "kishore-test-again-delete-me-staging-lite",
  true
)

note that there will be two apps being created in amplify. Staging lite will have the redirect rules for images + files, while the main app will have just the main 404 redirect.

Stg lite
Screenshot 2023-11-16 at 9 37 51 AM
Screenshot 2023-11-16 at 9 37 45 AM

Stg
Screenshot 2023-11-16 at 9 37 31 AM
Screenshot 2023-11-16 at 9 37 26 AM

when visiting stg lite, we should see the images as such : https://staging-lite.da33yn9c7fu8b.amplifyapp.com/images/favicon-isomer.ico

@kishore03109 kishore03109 requested review from isomer-demo and a team and removed request for isomer-demo November 16, 2023 02:49
@kishore03109 kishore03109 requested review from harishv7 and a team November 16, 2023 02:55
@kishore03109 kishore03109 merged commit 169b004 into develop Nov 16, 2023
10 checks passed
@mergify mergify bot deleted the fix/siteCreate branch November 16, 2023 04:55
@harishv7
Copy link
Contributor

Verified that the apps are created, imgs loading (e.g. https://staging-lite.da2l10qaui7tv.amplifyapp.com/images/favicon-isomer.ico)
cc @kishore03109

This was referenced Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants