Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use cTimeMs instead of birthtime due to EFS #1035

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Nov 14, 2023

Problem

Birth time shows 0 on EFS for some weird reason.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible with ALL of the following feature flags in this doc

Features:

  • Details ...

Improvements:

  • Details ...

Bug Fixes:

  • Details ...

Before & After Screenshots

BEFORE:

AFTER:

Tests

Deploy Notes

New environment variables:

  • env var : env var details
    • added env var to 1PW + SSM script (fetch_ssm_parameters.sh)

New scripts:

  • script : script details

New dependencies:

  • dependency : dependency details

New dev dependencies:

  • dependency : dependency details

@dcshzj dcshzj requested a review from a team November 14, 2023 10:31
@dcshzj dcshzj merged commit c74ee84 into develop Nov 14, 2023
22 checks passed
@mergify mergify bot deleted the fix/use-ctime-instead branch November 14, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants